Issue 635729 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	sque@chromium.org
Closed:	Sep 2016
Cc:	█ chongjiang@chromium.org
Components:	OS>Systems
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
cwp VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Quipper is not sending kernel DSOs

Project Member Reported by sque@chromium.org, Aug 9 2016

Issue description

Dev channel 8637.0.0

The ARC++ changes that landed on 14 July are now being pushed out to a large number of dev channel users.

The changes result in quipper getting build ID info by reading from the file system rather than from the perf data. But there is no supported way to get kernel build IDs from the file system (using dso.h).

A solution is to collect build IDs from the perf data first and then overwrite them if the file system contains different build IDs for a given DSO. If there is no build ID available in the file system (e.g. for kernel), then just keep the build ID obtained from perf data.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f537e4593889d3241530ff36e3bc3b11899558a9

commit f537e4593889d3241530ff36e3bc3b11899558a9
Author: Simon Que <sque@chromium.org>
Date: Tue Aug 09 00:03:14 2016

quipper: Collect and overwrite existing build IDs

Previously, the behavior of quipper was changed to get build IDs from
the file system rather than from the perf data. However, not all the
DSOs could have their build ID read from file system using dso.h, most
importantly the kernel.

This patch changes the behavior to collect build IDs from perf data,
as was originally done, but overwriting them with new build IDs from
dso.h, if available.

BUG= chromium:635729 
TEST=unit tests pass

Change-Id: I9e002e59268b973a21e4b722d544e9538d619408
Reviewed-on: https://chromium-review.googlesource.com/367017
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Simon Que <sque@chromium.org>
Reviewed-by: Chong Jiang <chongjiang@chromium.org>

[modify] https://crrev.com/f537e4593889d3241530ff36e3bc3b11899558a9/chromiumos-wide-profiling/perf_recorder_test.cc
[modify] https://crrev.com/f537e4593889d3241530ff36e3bc3b11899558a9/chromiumos-wide-profiling/perf_recorder.cc
[modify] https://crrev.com/f537e4593889d3241530ff36e3bc3b11899558a9/chromiumos-wide-profiling/perf_parser.cc
[modify] https://crrev.com/f537e4593889d3241530ff36e3bc3b11899558a9/chromiumos-wide-profiling/perf_parser.h
[modify] https://crrev.com/f537e4593889d3241530ff36e3bc3b11899558a9/chromiumos-wide-profiling/perf_parser_test.cc