New issue
Advanced search Search tips

Issue 635721 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"file not found" as a result of offline page expiration.

Project Member Reported by dim...@chromium.org, Aug 9 2016

Issue description

We have reports from the users (Tal is one of them) that after 2-day expiration time, if the tab with offline page is still open and user brings it to a foreground while offline, the tab will show "File not found" error.

Looking at the code at OfflinePageTabHelper, I see that if we are re-inflating the tab that was showing offline snapshot while offline, we go try to fetch the offline pages for the URL - and find none, since the URL is already file:// URL of an offline snapshot... Then we bail out and continue to show the page as is, simply failing to find a file.

Instead, we could have realized that the offline URL is for 'expired' page (which has no file but still kept in the database for few weeks) and instead map back to online URL and renavigate to that. It'll show dino page if offline, but it's better than a "file not found"... 
 
Components: UI>Browser>Offline
Labels: -Pri-3 OS-Android Pri-1
Owner: chili@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by chili@chromium.org, Aug 12 2016

Owner: jianli@chromium.org
Reassigning to Jian.  This should be fixed with his new interceptor code, so he can close this when that lands :)

Comment 3 by chili@chromium.org, Aug 25 2016

Issue 639529 has been merged into this issue.

Comment 4 by jianli@chromium.org, Aug 26 2016

Status: Fixed (was: Assigned)
This has been fixed after we switched to serving offline content directly under online URL as in patch https://codereview.chromium.org/2245733004/.
Status: Verified (was: Fixed)
Verified Fixed in 55.0.2862.0 we show the offline error page in this situation now.

Sign in to add a comment