New issue
Advanced search Search tips

Issue 635711 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 635685



Sign in to add a comment

Refactor Helium 0.5 transport implementation to Helium 1.0 transport API

Project Member Reported by w...@chromium.org, Aug 9 2016

Issue description

Refactor our existing TLS/TCP transport to provide the v1.0 transport API, to expedite development.
 

Comment 1 by w...@chromium.org, Aug 9 2016

Components: Mobile>Blimp
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/449e2fc928a4a579182f6f49f4defbfcec2b1c4c

commit 449e2fc928a4a579182f6f49f4defbfcec2b1c4c
Author: kmarshall <kmarshall@chromium.org>
Date: Thu Aug 25 02:00:51 2016

Decouple Blimp transport output from BlimpConnections using MessagePort.

This seam allows us to reuse our existing network connection factories for
hypothetical future non-BlimpConnection connection objects.

Also modified/rewrote existing unit tests to accommodate new API.

R=wez@chromium.org,lethalantidote@chromium.org
BUG= 635711 

Review-Url: https://codereview.chromium.org/2236093002
Cr-Commit-Position: refs/heads/master@{#414245}

[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/BUILD.gn
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/blimp_connection.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/blimp_connection.h
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/blimp_connection_unittest.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/blimp_transport.h
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/client_connection_manager.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/client_connection_manager_unittest.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/engine_authentication_handler_unittest.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/engine_connection_manager.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/engine_connection_manager_unittest.cc
[add] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/message_port.cc
[add] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/message_port.h
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/ssl_client_transport_unittest.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/tcp_client_transport.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/tcp_client_transport.h
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/tcp_engine_transport.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/tcp_engine_transport.h
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/tcp_transport_unittest.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/test_common.cc
[modify] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/blimp/net/test_common.h

Owner: ----
Status: Available (was: Started)
Status: WontFix (was: Available)
Obsolete, WontFix.
Labels: Archive-Blimp

Sign in to add a comment