The icons are padded incorrectly when Virtual Keyboard tray is active with vertical shelf alignment |
|||
Issue descriptionVersion: 54.0.2824.0 OS: Chrome OS What steps will reproduce the problem? (1) Launch chrome with Virtual Keyboard tray enabled (a11y) (2) Change shelf alignment to Left or Right What is the expected output? VK tray icon centered What do you see instead? See attached screenshot Please use labels and text to provide additional information. Broken with https://codereview.chromium.org/2201323002.
,
Aug 9 2016
I have worked on re-design the hitting mask in my cl https://codereview.chromium.org/2147143002/, my cl can fix this bug. @mohsen, you can assign this one to me.
,
Aug 9 2016
Did https://codereview.chromium.org/2201323002 also cause the user icon and notification center icon to shift right?
,
Aug 9 2016
Re #3: Yes; Apparently, the bigger size of VK button makes other elements wider.
,
Aug 9 2016
Re #2: I have uploaded a one-line fix: https://crrev.com/2221283002.
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e174a0faee78a356b775b16a1444f52d1dd319e5 commit e174a0faee78a356b775b16a1444f52d1dd319e5 Author: mohsen <mohsen@chromium.org> Date: Tue Aug 09 17:54:27 2016 Fix VirtualKeyboardTray border We need to set a null border for VirtualKeyboardTray every time shelf alignment changes. This was regressed in r410413 which simplified VirtualKeyboardTray's View hierarchy. BUG= 635706 TEST=none Review-Url: https://codereview.chromium.org/2221283002 Cr-Commit-Position: refs/heads/master@{#410736} [modify] https://crrev.com/e174a0faee78a356b775b16a1444f52d1dd319e5/ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
,
Aug 10 2016
,
Oct 19 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by moh...@chromium.org
, Aug 9 2016