New issue
Advanced search Search tips

Issue 635678 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Network quality estimator should adjust the intervals at which effective connection type is recomputed

Project Member Reported by tbansal@chromium.org, Aug 8 2016

Issue description

Network quality estimator (NQE) should dynamically adjust the intervals at which effective connection type (ECT) is recomputed.

Currently, NQE recomputes ECT every 15 seconds. However, this duration is too long at the time of Chromium startup or right after Android triggers a  connection change event because this is the time when the RTT and bandwidth samples have started to come in, and ECT is expected to change (and converge) rapidly.

To address this, NQE should proactively recompute ECT if the ECT is *expected* to change. This can be approximated by looking at the number of RTT and bandwidth samples available. If the number of samples have changed significantly, then NQE should recompute the ECT without waiting for 15 second trigger.




 
Summary: Network quality estimator should adjust the intervals at which effective connection type is recomputed (was: NQE: Network quality estimator should dynamically adjust the intervals at which effective connection type is recomputed)
Labels: NQE
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd91c073a0b04aebd67b890a7c3cea13ac1da4d

commit dbd91c073a0b04aebd67b890a7c3cea13ac1da4d
Author: tbansal <tbansal@chromium.org>
Date: Fri Aug 12 22:36:24 2016

Compute effective connection type dynamically

This CL changes the behavior of how Network Quality Estimator
(NQE) computes Effective Connection Type (ECT). Currently,
ECT is computed regularly at 15 second intervals.

This CL changes that behavior to additionally recompute the
ECT under two more conditions:
(1) Recompute the effective connection type (ECT) if the
number of RTT or bandwidth samples have more than doubled
since the last computation.
(2) Recompute the effective connection type (ECT) if the
previously computed ECT value was Unknown.

BUG= 635678 

Review-Url: https://codereview.chromium.org/2221103003
Cr-Commit-Position: refs/heads/master@{#411803}

[modify] https://crrev.com/dbd91c073a0b04aebd67b890a7c3cea13ac1da4d/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/dbd91c073a0b04aebd67b890a7c3cea13ac1da4d/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/dbd91c073a0b04aebd67b890a7c3cea13ac1da4d/net/nqe/network_quality_estimator_unittest.cc

Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality
Labels: -nqe

Sign in to add a comment