[Accessibility] No singular version of tab switcher button description |
||||
Issue descriptionTurn on talk back from device settings/Accessibility Steps to reproduce: (1) Launch app (2) Open a single tab (3) Tap tab switcher button Expected result: Talk back reads: 1 open tab Actual result: Talk back reads: 1 open tabs
,
Aug 11 2016
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73c8f25a22e43a9cfab595782258d39b6dafac52 commit 73c8f25a22e43a9cfab595782258d39b6dafac52 Author: estevenson <estevenson@chromium.org> Date: Tue Aug 16 14:29:17 2016 Handle both plural and singular tab switcher content descriptions. This CL changes the tab switcher to use the correct grammatical category of the number of tabs open. BUG= 635677 Review-Url: https://codereview.chromium.org/2222013004 Cr-Commit-Position: refs/heads/master@{#412231} [modify] https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52/build/android/lint/suppressions.xml [modify] https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52/chrome/android/java/res/layout-sw600dp/toolbar.xml [modify] https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52/chrome/android/java/res/layout/toolbar.xml [modify] https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java [modify] https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java [modify] https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52/chrome/android/java/strings/android_chrome_strings.grd
,
Aug 19 2016
,
Aug 23 2016
Verified in 54.0.2837.2 build |
||||
►
Sign in to add a comment |
||||
Comment 1 by estevenson@chromium.org
, Aug 8 2016