New issue
Advanced search Search tips

Issue 635670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 625841



Sign in to add a comment

Removing MouseButton enum and related fields

Project Member Reported by nzolghadr@chromium.org, Aug 8 2016

Issue description

Moving towards PlatformPointerEvent, there is some need to cleanup some of the common/redundant fields and structures.
For example m_button field in PlatformMouseButton and MouseButton enum in the same class should be removed

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/PlatformMouseEvent.h?q=PlatformMouseEvent&sq=package:chromium&dr=CSs&l=38
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/PlatformMouseEvent.h?q=PlatformMouseEvent&sq=package:chromium&dr=CSs&l=105

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3acb734ff34a77e76228425d06952317c10e252b

commit 3acb734ff34a77e76228425d06952317c10e252b
Author: nzolghadr <nzolghadr@chromium.org>
Date: Wed Aug 17 16:25:32 2016

Refactoring button field and its type

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all pointerevents (similar to mouseevent) should be null except for boundary events. So relatedTarget can be removed from some of the functions as they don't send boundary events.

BUG= 635670 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2227563003
Cr-Commit-Position: refs/heads/master@{#412552}

[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/apps/window_controls_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/history/history_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/history/redirect_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/password_manager/password_manager_interactive_uitest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/referrer_policy_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/browser/unload_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/chrome/test/remoting/remote_desktop_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/components/test_runner/event_sender.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/components/test_runner/event_sender.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/main_thread_event_queue_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/input/web_input_event_builders_win.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/web_input_event_aura.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/renderer_host/web_input_event_aura_unittest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/common/input/web_input_event_traits.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/public/test/render_view_test.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/renderer/webscrollbarbehavior_impl_gtkoraura.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/renderer/webscrollbarbehavior_impl_gtkoraura.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/renderer/webscrollbarbehavior_impl_mac.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/content/renderer/webscrollbarbehavior_impl_mac.mm
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/mojo/converters/blink/blink_input_events_type_converters.cc
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/events/PointerEventFactory.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/input/PointerEventManager.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/page/AutoscrollController.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/platform/PlatformMouseEvent.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/public/platform/WebPointerProperties.h
[modify] https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b/third_party/WebKit/public/platform/WebScrollbarBehavior.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c1f8f7a786bb441229143629a30048f187bf937

commit 1c1f8f7a786bb441229143629a30048f187bf937
Author: megjablon <megjablon@chromium.org>
Date: Wed Aug 17 23:14:02 2016

Revert of Refactoring button field and its type (patchset #13 id:240001 of https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/11748

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
>
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
>
> - Also cleanup related target for pointerevents. The related target for all pointerevents (similar to mouseevent) should be null except for boundary events. So relatedTarget can be removed from some of the functions as they don't send boundary events.
>
> BUG= 635670 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pfeldman@chromium.org
>
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium.org,pfeldman@chromium.org,danakj@chromium.org,sky@chromium.org,thestig@chromium.org,nzolghadr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG= 635670 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2245063006
Cr-Commit-Position: refs/heads/master@{#412684}

[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/apps/window_controls_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/history/history_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/history/redirect_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/password_manager/password_manager_interactive_uitest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/referrer_policy_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/browser/unload_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/chrome/test/remoting/remote_desktop_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/components/test_runner/event_sender.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/components/test_runner/event_sender.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/main_thread_event_queue_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/input/web_input_event_builders_win.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/web_input_event_aura.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/renderer_host/web_input_event_aura_unittest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/public/test/render_view_test.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/renderer/webscrollbarbehavior_impl_gtkoraura.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/renderer/webscrollbarbehavior_impl_gtkoraura.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/renderer/webscrollbarbehavior_impl_mac.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/content/renderer/webscrollbarbehavior_impl_mac.mm
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/mojo/converters/blink/blink_input_events_type_converters.cc
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/events/PointerEventFactory.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/input/PointerEventManager.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/page/AutoscrollController.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/platform/PlatformMouseEvent.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/public/platform/WebPointerProperties.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/third_party/WebKit/public/platform/WebScrollbarBehavior.h
[modify] https://crrev.com/1c1f8f7a786bb441229143629a30048f187bf937/ui/events/blink/web_input_event_traits.cc

Comment 4 by mustaq@chromium.org, Aug 19 2016

Status: Assigned (was: Fixed)
Just to update the bug here. The original code got reverted due to the change in enum sizes. I thought I can easily change the enum sizes from the default which is int to int8. However, that caused the msan bots give uninitialized check errors. I change the enums sizes back to the default int and re-submit the patch.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/656569e7720f728ee023447a270376ed17754dfc

commit 656569e7720f728ee023447a270376ed17754dfc
Author: nzolghadr <nzolghadr@chromium.org>
Date: Fri Aug 19 16:53:00 2016

Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all pointerevents (similar to mouseevent) should be null except for boundary events. So relatedTarget can be removed from some of the functions as they don't send boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org, mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org, thestig@chromium.org

BUG= 635670 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2252423002
Cr-Commit-Position: refs/heads/master@{#413168}

[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/apps/window_controls_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/history/history_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/history/redirect_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/password_manager/password_manager_interactive_uitest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/referrer_policy_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/browser/unload_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/chrome/test/remoting/remote_desktop_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/components/test_runner/event_sender.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/components/test_runner/event_sender.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/main_thread_event_queue_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/public/test/render_view_test.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/renderer/webscrollbarbehavior_impl_gtkoraura.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/renderer/webscrollbarbehavior_impl_gtkoraura.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/renderer/webscrollbarbehavior_impl_mac.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/content/renderer/webscrollbarbehavior_impl_mac.mm
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/mojo/converters/blink/blink_input_events_type_converters.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/events/PointerEventFactory.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/input/PointerEventManager.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/page/AutoscrollController.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/platform/PlatformMouseEvent.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/public/platform/WebPointerProperties.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/third_party/WebKit/public/platform/WebScrollbarBehavior.h
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/ui/events/blink/web_input_event_builders_win.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/656569e7720f728ee023447a270376ed17754dfc/ui/events/blink/web_input_event_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment