Issue 635666 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	martiniss@chromium.org
Closed:	Aug 2016
Cc:	seanmccullough@chromium.org martiniss@chromium.org zhangtiff@chromium.org
Components:	Infra>Sheriffing>SheriffOMatic
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	----
Infra-DX Milestone-SoMNG

Code search broken for android tree

Project Member Reported by martiniss@chromium.org, Aug 8 2016

Issue description

Problem with Sheriff-o-Matic:

Code search links are broken for android; we get links like https://cs.chromium.org/org.chromium.chrome.browser.compositor.overlays.strip.TabStripTest#testScrollingStripStackerScrollsToSelectedTab
which gets parsed strangely by code search.

I'll change it to more nicely encode parameters.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/2f249bb530ca7711d7db838ddf8f0d67aaea712c

commit 2f249bb530ca7711d7db838ddf8f0d67aaea712c
Author: Stephen Martinis <martiniss@chromium.org>
Date: Wed Aug 10 01:33:43 2016

SOM: Fix code search links

BUG= 635666 

Change-Id: Icfd2de7bc96f6c524d9100e25103bd404fb220e5
Reviewed-on: https://chromium-review.googlesource.com/367087
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/2f249bb530ca7711d7db838ddf8f0d67aaea712c/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html
[modify] https://crrev.com/2f249bb530ca7711d7db838ddf8f0d67aaea712c/go/src/infra/appengine/sheriff-o-matic/test/som-extension-build-failure-test.html

Comment 2 by zhangtiff@chromium.org, Aug 10 2016

Labels: Milestone-SoMNG

Comment 3 by martiniss@chromium.org, Aug 11 2016

Status: Fixed (was: Started)

This fix landed.

►

Issue 635666 link

Issue metadata

Code search broken for android tree

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

Comment 1 Deleted

Comment 2 by zhangtiff@chromium.org, Aug 10 2016

Comment 2 Deleted

Comment 3 by martiniss@chromium.org, Aug 11 2016

Comment 3 Deleted

Sign in to add a comment