New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635663 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Integer-overflow in CStretchEngine::CStretchEngine

Project Member Reported by ClusterFuzz, Aug 8 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6534202604650496

Fuzzer: tokenfuzz_pdf_curated
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  CStretchEngine::CStretchEngine
  CFX_ImageStretcher::StartStretch
  CFX_ImageStretcher::Start
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027

Minimized Testcase (1353.17 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94HEbPPWiCWRL2EkC8OhivKr99HFm8PONLrB2mUei6AeebFV8W-Vuxqd5XdXsAxVySyIH7Wf1Xh4xR4x8lVyurkRnRYEs5tJNBdcmiZGYYGAestaiXw1I5NygFJ1nUabirjRl_96bWt9y6uNuVQF_55XtBnFvqCnzd01Wsx3KhI7h8btEo?testcase_id=6534202604650496

Issue manually filed by: mmohammad

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Owner: weili@chromium.org
Status: Assigned (was: Untriaged)
might be a suspected:
Changelist: https://pdfium.googlesource.com/pdfium.git/+/c38cd6eb274429a5755e04d2e22a606375851717
weili@ could you please look into this. feel free to re assign back thanks in advance
Cc: thestig@chromium.org och...@chromium.org ranjitkan@chromium.org dsinclair@chromium.org
 Issue 618696  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/229d05df5bc5deb3890b26b614113c25d9b6935e

commit 229d05df5bc5deb3890b26b614113c25d9b6935e
Author: weili <weili@chromium.org>
Date: Fri Aug 12 02:43:58 2016

Fix an integer overflow in CStretchEngine constructor

When the source bitmap's width and height are large,
the multiplication could easily overflow a signed integer.
Change to use 'long long' type for calculation to avoid that.

BUG= chromium:635663 

Review-Url: https://codereview.chromium.org/2240723002

[modify] https://crrev.com/229d05df5bc5deb3890b26b614113c25d9b6935e/BUILD.gn
[modify] https://crrev.com/229d05df5bc5deb3890b26b614113c25d9b6935e/core/fxge/dib/fx_dib_engine.cpp
[add] https://crrev.com/229d05df5bc5deb3890b26b614113c25d9b6935e/core/fxge/dib/fx_dib_engine_unittest.cpp
[modify] https://crrev.com/229d05df5bc5deb3890b26b614113c25d9b6935e/pdfium.gyp

Comment 5 by weili@chromium.org, Aug 12 2016

Status: Fixed (was: Assigned)
This doesn't seem to be a regression. But fixed now.
Project Member

Comment 6 by ClusterFuzz, Aug 13 2016

ClusterFuzz has detected this issue as fixed in range 411529:411868.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6534202604650496

Fuzzer: tokenfuzz_pdf_curated
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  CStretchEngine::CStretchEngine
  CFX_ImageStretcher::StartStretch
  CFX_ImageStretcher::Start
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=411529:411868

Minimized Testcase (1353.17 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94HEbPPWiCWRL2EkC8OhivKr99HFm8PONLrB2mUei6AeebFV8W-Vuxqd5XdXsAxVySyIH7Wf1Xh4xR4x8lVyurkRnRYEs5tJNBdcmiZGYYGAestaiXw1I5NygFJ1nUabirjRl_96bWt9y6uNuVQF_55XtBnFvqCnzd01Wsx3KhI7h8btEo?testcase_id=6534202604650496

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Internals>Plugins>PDF

Sign in to add a comment