New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635658 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 3
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

swconfig vs DSA : why isn't Onhub using DSA to manage switch routing?

Project Member Reported by grundler@chromium.org, Aug 8 2016

Issue description


Qualcomm has been pushing Onhub to use it's swconfig user space and kernel infrastructure. I'm assuming it's because this is what they were able to push into openwrt.org or leverage from openwrt.

But they've offered no support for DSA and not even made us aware of DSA or what it does (or does not do). I'd like to understand is why QCA isn't offering DSA support in upstream kernel. There must be some good reasons for it.

I'm filing this bug to re-open that conversation since DSA was added *8 years ago* (2.6.38?) and is supported by both Marvell and Broadcom to some degree today.

commit 91da11f870f00a3322b81c73042291d7f0be5a17
Author: Lennert Buytenhek <buytenh@wantstofly.org>
Date:   Tue Oct 7 13:44:02 2008 +0000

    net: Distributed Switch Architecture protocol support
    
    Distributed Switch Architecture is a protocol for managing hardware
    switch chips.  It consists of a set of MII management registers and
    commands to configure the switch, and an ethernet header format to
    signal which of the ports of the switch a packet was received from
    or is intended to be sent to.
    
    The switches that this driver supports are typically embedded in
    access points and routers, and a typical setup with a DSA switch
    looks something like this:
    
        +-----------+       +-----------+
        |           | RGMII |           |
        |           +-------+           +------ 1000baseT MDI ("WAN")
        |           |       |  6-port   +------ 1000baseT MDI ("LAN1")
        |    CPU    |       |  ethernet +------ 1000baseT MDI ("LAN2")
        |           |MIImgmt|  switch   +------ 1000baseT MDI ("LAN3")
        |           +-------+  w/5 PHYs +------ 1000baseT MDI ("LAN4")
        |           |       |           |
        +-----------+       +-----------+
    
    The switch driver presents each port on the switch as a separate
    network interface to Linux, polls the switch to maintain software
    link state of those ports, forwards MII management interface
    accesses to those network interfaces (e.g. as done by ethtool) to
    the switch, and exposes the switch's hardware statistics counters
    via the appropriate Linux kernel interfaces.
    
    This initial patch supports the MII management interface register
    layout of the Marvell 88E6123, 88E6161 and 88E6165 switch chips, and
    supports the "Ethertype DSA" packet tagging format.
    
    (There is no officially registered ethertype for the Ethertype DSA
    packet format, so we just grab a random one.  The ethertype to use
    is programmed into the switch, and the switch driver uses the value
    of ETH_P_EDSA for this, so this define can be changed at any time in
    the future if the one we chose is allocated to another protocol or
    if Ethertype DSA gets its own officially registered ethertype, and
    everything will continue to work.)
    
    Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
    Tested-by: Nicolas Pitre <nico@marvell.com>
    Tested-by: Byron Bradley <byron.bbradley@gmail.com>
    Tested-by: Tim Ellis <tim.ellis@mac.com>
    Tested-by: Peter van Valderen <linux@ddcrew.com>
    Tested-by: Dirk Teurlings <dirk@upexia.nl>
    Signed-off-by: David S. Miller <davem@davemloft.net>

 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 9 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by quiche@chromium.org, May 22 2018

Cc: -quiche@chromium.org
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Cc: -kevinhayes@chromium.org kevinhayes@google.com kkunduru@chromium.org sduvvuri@google.com
Owner: grundler@chromium.org
Status: WontFix (was: Assigned)
Can Jetstream team try to avoid adding a new subsystem with with next product?

Sign in to add a comment