Issue metadata
Sign in to add a comment
|
Regression: Can't copy from OSX interstitial page (again) |
||||||||||||||||||||
Issue descriptionChrome 54.0.2823.0 OSX 10.11.6 What steps will reproduce the problem? (1) Visit expired.badssl.com (2) Try to copy text from the interstitial page. What is the expected output? Clipboard contains the text you tried to copy. What do you see instead? Nothing is copied. This is a regression of the fix for Issue 415784 . :-(
,
Aug 8 2016
Not really. I've not worked much in this area of code since then.
,
Aug 9 2016
You are probably looking for a change made after 408443 (known good), but no later than 408464 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/6487a75725fcfa61b963ca8d9abc8e8847fc002a..fc1a80d5d329dd4a1cce9886cadf85100f1edcb4 --------- Suspecting: commit 0206f78f31bafd45b2a9479d0311b4e7e11acf7a author avallee <avallee@chromium.org> Thu Jul 28 18:55:33 2016 Fix keyboard focus for OOPIF-<webview>. Review-Url: https://codereview.chromium.org/1934703002
,
Feb 28 2017
avallee@: ping
,
Feb 28 2017
,
Mar 1 2017
I don't think this was caused by my change, however, it seems that the interstitial does not have a focused frame which ends up nopping the copy. https://cs.chromium.org/chromium/src/content/browser/frame_host/interstitial_page_impl.cc?l=438
,
Mar 1 2017
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ae3030718bc7e0673868ae81b33a3cccd663e62 commit 0ae3030718bc7e0673868ae81b33a3cccd663e62 Author: avallee <avallee@chromium.org> Date: Wed Mar 01 21:27:41 2017 Fix broken copy-paste operations on Interstitial pages. The RenderFrameHostDelegate::SetFocusedFrame function was added to keep track of inner web contents but the base implementation in the delegate that is a no-op broken interstitial pages which also need to keep track of the focused frame. BUG= 635656 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2727483003 Cr-Commit-Position: refs/heads/master@{#454038} [modify] https://crrev.com/0ae3030718bc7e0673868ae81b33a3cccd663e62/content/browser/frame_host/interstitial_page_impl.cc [modify] https://crrev.com/0ae3030718bc7e0673868ae81b33a3cccd663e62/content/browser/frame_host/interstitial_page_impl.h
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a15baef08261f53209cd171e4ea200e221fc162 commit 1a15baef08261f53209cd171e4ea200e221fc162 Author: avallee <avallee@chromium.org> Date: Wed Mar 01 23:43:58 2017 Fix InterstitialPageImplTest to fail if frame is not focused correctly. See failing tests on https://codereview.chromium.org/2721303003 to show tests fail (hang) with this test fix, but without the impl fix. BUG= 635656 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2728753002 Cr-Commit-Position: refs/heads/master@{#454097} [modify] https://crrev.com/1a15baef08261f53209cd171e4ea200e221fc162/content/browser/frame_host/interstitial_page_impl_browsertest.cc
,
Mar 1 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Aug 8 2016