New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635655 link

Starred by 4 users
Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
ikilpatrick@chromium.org
r...@igalia.com
█ glebl@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Reduce code duplication between availableLogicalHeightUsing() and computePercentageLogicalHeight()

Project Member Reported by cbiesin...@chromium.org, Aug 8 2016 
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/LayoutBox.cpp?q=availableLogicalHeight&sq=package:chromium&l=3036&dr=CSs

availableLogicalHeightUsing gets the height of an element's containing block using its style, as would be needed for percentage resolution (as far as I can tell). But computePercentageLogicalHeight does not use this function, instead implementing similar functionality separately. That code duplication seems bad?

Comment 1 by e...@chromium.org, Aug 12 2016

Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)

Comment 2 by r...@igalia.com, Aug 16 2016 

It'd be nice to also take a look to LayoutBox::computeReplacedLogicalHeightUsing() and LayoutBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight().
We've a bunch of duplicated logic there too.

Comment 3 by joone....@intel.com, Nov 30 2016

Labels: -OS-Windows OS-All

Comment 4 by e...@chromium.org, Nov 30 2017

Status: WontFix (was: Available)
Addressed as part of LayoutNG.
►

Sign in to add a comment