New issue
Advanced search Search tips

Issue 635649 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

oortonline_tbmv2 failure on Windows chromium.perf

Project Member Reported by sullivan@chromium.org, Aug 8 2016

Issue description

Ulan, this seems to be failing since it was converted to tbm2 (r410329 is in the revision range). I'm disabling on Windows until it can be investigated.

Revision range first seen: 410320:410331
Link to failing step log:
https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf%20%281%29/builds/5578
https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf%20%281%29/builds/2433
https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf%20%281%29/builds/4140
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20Zenbook%20Perf%20(1)/builds/2433/steps/oortonline_tbmv2/logs/stdio
ERROR) 2016-08-08 05:55:08,545 tracing_controller_backend.CollectAgentTraceData:275  Error when deleting c:\users\chrome~2\appdata\local\temp\tmpx_l_co, will try again at 
exit.
Traceback (most recent call last):
  File "C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_controller_backend.py", line 271, in CollectAgentTraceData
    os.remove(self._trace_log)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\users\\chrome~2\\appdata\\local\\temp\\tmpx_l_co'
(INFO) 2016-08-08 05:55:44,665 trace._GetTempFileHandle:65  Trace (TraceDataPart("traceEvents")) of size 31069331 bytes saved.
(INFO) 2016-08-08 05:55:44,678 trace._GetTempFileHandle:65  Trace (TraceDataPart("tabIds")) of size 40 bytes saved.
(INFO) 2016-08-08 05:55:44,694 trace._GetTempFileHandle:65  Trace (TraceDataPart("telemetry")) of size 894 bytes saved.
[ RUN      ] c:\users\chrome~2\appdata\local\temp\tmphyzpx6.html
MapFunctionError: Can't add a sample with a non-DiagnosticMap
    at Object.add (/tracing/value/numeric.html:385:15)
    at eval (/tracing/metrics/system_health/responsiveness_metric.html:102:25)
    at Object.forEach (/tracing/model/event_set.html:251:12)
    at new responsivenessMetric (/tracing/metrics/system_health/responsiveness_metric.html:86:34)
    at metricMapFunction (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\tracing\tracing\metrics\metric_map_function.html:36:14)
    at Object.mapSingleTrace (/perf_insights/mre/map_single_trace.html:41:7)
    at eval (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\perf_insights\perf_insights\mre\map_single_trace_cmdline.html:61:14)
    at Object.runAndConvertErrorsToFailures (/perf_insights/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\perf_insights\perf_insights\mre\map_single_trace_cmdline.html:52:8)
    at Object.mapSingleTraceMain (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\perf_insights\perf_insights\mre\map_single_trace_cmdline.html:76:18)
[  FAILED  ] c:\users\chrome~2\appdata\local\temp\tmphyzpx6.html (46112 ms)
Traceback (most recent call last):
  File "C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\telemetry\telemetry\value\failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: MapFunctionError: Can't add a sample with a non-DiagnosticMap
    at Object.add (/tracing/value/numeric.html:385:15)
    at eval (/tracing/metrics/system_health/responsiveness_metric.html:102:25)
    at Object.forEach (/tracing/model/event_set.html:251:12)
    at new responsivenessMetric (/tracing/metrics/system_health/responsiveness_metric.html:86:34)
    at metricMapFunction (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\tracing\tracing\metrics\metric_map_function.html:36:14)
    at Object.mapSingleTrace (/perf_insights/mre/map_single_trace.html:41:7)
    at eval (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\perf_insights\perf_insights\mre\map_single_trace_cmdline.html:61:14)
    at Object.runAndConvertErrorsToFailures (/perf_insights/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\perf_insights\perf_insights\mre\map_single_trace_cmdline.html:52:8)
    at Object.mapSingleTraceMain (C:\b\c\b\Win_Zenbook_Perf__1_\src\third_party\catapult\perf_insights\perf_insights\mre\map_single_trace_cmdline.html:76:18)

[  FAILED  ] http://oortonline.gl/#run (195675 ms)
(INFO) 2016-08-08 05:57:21,628 desktop_browser_backend._TryCooperativeShutdown:570  Successfully shut down browser cooperatively
(INFO) 2016-08-08 05:57:22,815 cloud_storage.Insert:292  Uploading c:\users\chrome~2\appdata\local\temp\tmphyzpx6.html to gs://chrome-telemetry-output/trace-file-id_0-2016-08-08_05-57-22-78766.html
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ]  http://oortonline.gl/#run

1 FAILED TEST

 
Status: Assigned (was: Untriaged)
sheriff ping!

Comment 3 by u...@chromium.org, Aug 30 2016

Cc: benjhayden@chromium.org
benjhayden, this benchmark was failing because responsivenessMetric added "a sample with a non-DiagnosticMap".

Do you think, https://codereview.chromium.org/2258583003 might have fixed it?

Sorry, is something still broken?
Should we re-enable the benchmark and test if Ben's CL fixed it?
Cc: -benjhayden@chromium.org u...@chromium.org
Owner: benjhayden@chromium.org
https://codereview.chromium.org/2367213002
Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/409e5d2675dc8753e6e7d0cddd05e4302a978a46

commit 409e5d2675dc8753e6e7d0cddd05e4302a978a46
Author: benjhayden <benjhayden@chromium.org>
Date: Tue Sep 27 18:11:16 2016

Re-enable oortonline_tbmv2 benchmark on all platforms.

BUG= 635649 , 540022 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2367213002
Cr-Commit-Position: refs/heads/master@{#421269}

[modify] https://crrev.com/409e5d2675dc8753e6e7d0cddd05e4302a978a46/tools/perf/benchmarks/oortonline.py

Sign in to add a comment