Issue 635644 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ chili@chromium.org Last visit 22 days ago
Closed:	Sep 2016
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Move Java side GUID based Client ID generation to a central place

Project Member Reported by fgor...@chromium.org, Aug 8 2016

Issue description

Move Java side GUID based Client ID generation to a central place:
* Either do it in the native code and expose through a bridge
* OR centralize it for all Java components, e.g. as a static method on ClientID / OfflinePageBridge.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/664f86feeb732c4d3bfd104a206343fccef37188

commit 664f86feeb732c4d3bfd104a206343fccef37188
Author: chili <chili@chromium.org>
Date: Fri Aug 26 18:23:36 2016

[Offline pages] Refactor createClientIdForTabSharing and ClientId/UUID creation

BUG= 635644 

Review-Url: https://codereview.chromium.org/2273373003
Cr-Commit-Position: refs/heads/master@{#414749}

[modify] https://crrev.com/664f86feeb732c4d3bfd104a206343fccef37188/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/ClientId.java
[modify] https://crrev.com/664f86feeb732c4d3bfd104a206343fccef37188/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/664f86feeb732c4d3bfd104a206343fccef37188/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Comment 2 by chili@chromium.org, Sep 6 2016

Status: Fixed (was: Started)

Fixed as far as I can see.  Please let me know if there's something I missed.

►

Issue 635644 link

Issue metadata

Move Java side GUID based Client ID generation to a central place

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 26 2016

Comment 1 Deleted

Comment 2 by chili@chromium.org, Sep 6 2016

Comment 2 Deleted

Sign in to add a comment