New issue
Advanced search Search tips

Issue 635638 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Convert ShelfView to wm common types

Project Member Reported by jamescook@chromium.org, Aug 8 2016

Issue description

It'll have to move with ShelfLayoutManager and ShelfWidget, but it needs to be expunged of aura first.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32250bef67ff5256c687c7817b306b55fed54493

commit 32250bef67ff5256c687c7817b306b55fed54493
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 09 00:21:03 2016

mash: Convert ShelfView to wm common types, clean up Shelf access

* Eliminate aura::Window from ShelfView
* Eliminate Shelf access from ShelfView in favor of WmShelf
* Remove some ash::Shell usage in ShelfView unit tests
* Move IsHorizontalAlignment, SelectValueForAlignment and PrimaryAxisValue
from Shelf to WmShelf and make them not templates
* Move files to //ash/common/shelf

BUG= 635638 
TEST=ash_unittests, unit_tests

Review-Url: https://codereview.chromium.org/2228713003
Cr-Commit-Position: refs/heads/master@{#410512}

[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/ash.gyp
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/DEPS
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/app_list_button.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/overflow_bubble.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/shelf_button.cc
[rename] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/shelf_icon_observer.h
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/shelf_tooltip_manager_unittest.cc
[rename] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/shelf_view.cc
[rename] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/shelf_view.h
[add] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/common/shelf/wm_shelf_util.h
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/shelf/shelf.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/shelf/shelf.h
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/shelf/shelf_unittest.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/test/shelf_view_test_api.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/ash/wm/window_animations.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc
[modify] https://crrev.com/32250bef67ff5256c687c7817b306b55fed54493/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

Status: Fixed (was: Started)
Done!

I went ahead and moved it since it only had a ShelfWidget dep remaining.

Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment