New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635633 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 715903
issue 715906



Sign in to add a comment

this file is deprecated. please use `iron-flex-layout/iron-flex-layout-classes.html`

Project Member Reported by michae...@chromium.org, Aug 8 2016

Issue description

We've been getting these warnings in chrome://md-settings for a while. We should just do what it says: use iron-flex-layout-classes.html instead of files in iron-flex-layout/classes.
 
Labels: -Pri-2 Hotlist-MD-Settings-General Pri-3
pri-3 is fair, but as a code health issue and performance question I still intend to address it :-)
Cc: michae...@chromium.org
Owner: ----
Status: Available (was: Started)
marking as "available" as I may not get around to finishing up the relevant CLs, but anyone can pick this up:

https://codereview.chromium.org/2236463005/
https://codereview.chromium.org/2221073004/
https://codereview.chromium.org/2231593003/

Comment 4 by dpa...@chromium.org, Apr 22 2017

Cc: dpa...@chromium.org
I am wondering if now is a good time to address this issue. Will take a look on what would be the scale of such a change.

Comment 5 by dpa...@chromium.org, Apr 22 2017

As noted by @michaelpg, the deprecation warning got a bit scarier lately, see attachement.

"[Deprecation] /deep/ combinator is deprecated and will be a no-op in M60, around August 2017"

I think that is one more reason to update our code.
warning.png
26.6 KB View Download

Comment 6 by dpa...@chromium.org, Apr 24 2017

Owner: dpa...@chromium.org
Status: Assigned (was: Available)

Comment 7 by dpa...@chromium.org, Apr 24 2017

Labels: -Pri-3 Pri-2

Comment 8 by dpa...@chromium.org, Apr 24 2017

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bccef5b96b6695d40407dc3c4a2e22212730256

commit 3bccef5b96b6695d40407dc3c4a2e22212730256
Author: dpapad <dpapad@chromium.org>
Date: Wed Apr 26 00:30:11 2017

WebUI: Unify [hidden] attribute styling rules.

This CL addresses MD Settings, History, Downloads and Bookmarks.
MD Extensions will be addressed in follow up CL.

BUG= 635633 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2838963003
Cr-Commit-Position: refs/heads/master@{#467180}

[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/chrome/browser/resources/md_bookmarks/shared_style.html
[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/chrome/browser/resources/md_downloads/manager.html
[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/chrome/browser/resources/settings/settings_shared_css.html
[add] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/ui/webui/resources/cr_elements/hidden_style_css.html
[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/ui/webui/resources/cr_elements/shared_style_css.html
[modify] https://crrev.com/3bccef5b96b6695d40407dc3c4a2e22212730256/ui/webui/resources/cr_elements_resources.grdp

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60869ccf490d8a71bdbe64bca909b80b0348d805

commit 60869ccf490d8a71bdbe64bca909b80b0348d805
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 27 00:34:07 2017

MD Settings: Remove usage of deprecated iron-flex-layout.html.

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG= 635633 
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2840713002
Cr-Commit-Position: refs/heads/master@{#467529}

[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/settings_page/settings_animated_pages.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/60869ccf490d8a71bdbe64bca909b80b0348d805/chrome/browser/resources/settings/site_settings/site_details.html

As I am converting the remaining CrOS UIs away from iron-flex-layout.html, I discovered something interesting (and unexpected).

In iron-flex-layout.html the "flex" class simply specifies "flex: 1", see [1]. On the other hand, in the new iron-flex-layout-classes.html the "flex" class also specifies an odd flex-basis value of 0.000000001px, which breaks some of our UIs. 

[1] https://github.com/PolymerElements/iron-flex-layout/blob/master/classes/iron-flex-layout.html#L92
[2] https://github.com/PolymerElements/iron-flex-layout/blob/master/iron-flex-layout-classes.html#L89
Blockedon: 715903
Blockedon: 715906
Blocking: 715407
Blocking: -715407
Blocking: 715407
Cc: shans@chromium.org
 Issue 715407  has been merged into this issue.
Blocking: -715407
Labels: -Pri-2 Pri-1
Increasing priority to match that of  issue 715407 .
Project Member

Comment 19 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abeb3b928b8834dd180f8b75ccca53b52d6cde55

commit abeb3b928b8834dd180f8b75ccca53b52d6cde55
Author: dpapad <dpapad@chromium.org>
Date: Mon May 01 23:24:56 2017

MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG= 635633 
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2848443002
Cr-Commit-Position: refs/heads/master@{#468480}

[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/network/cr_network_icon.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/network/cr_network_list.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/network/cr_network_list_item.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/network/cr_network_select.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/network/cr_network_select.js
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/policy/cr_policy_indicator.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
[modify] https://crrev.com/abeb3b928b8834dd180f8b75ccca53b52d6cde55/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html

Status: Fixed (was: Started)
@hayato: I believe that all the test failures you were seeing should be fixed now. Let me know if you are still having issues.
dpapad@, thank you for fixing this!

Sign in to add a comment