New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635629 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 307091



Sign in to add a comment

Overlay scrollbars don't appear on load

Project Member Reported by bokan@chromium.org, Aug 8 2016

Issue description

Version: 54.0.2816.0
OS: Linux

What steps will reproduce the problem?
(1) Enable chrome://flags/#overlay-scrollbars
(2) Navigate to any page with scrollbars

What is the expected output?
The shrunken, main frame overlay scrollbar should show up on load

What do you see instead?
The scrollbar isn't there until the first scroll. On scrolling or moving the mouse nearby, the scrollbar appears.

 

Comment 1 by bokan@chromium.org, Sep 2 2016

Owner: sahel@chromium.org
Sahel, ptal when you have a chance.

Comment 2 by sahel@chromium.org, Sep 14 2016

Status: Started (was: Available)

Comment 3 by bokan@chromium.org, Sep 22 2016

Labels: Hotlist-Input-Dev

Comment 4 by aelias@chromium.org, Sep 23 2016

Cc: skobes@chromium.org
Components: Blink>Layout>Scrollbars
Not exactly the right forum for discussing this, but I'm wondering why ChromeOS isn't simply adopting Android style scrollbars now.  With ARC++, you'll see a weirdly inconsistent mix of Android scrollbars and thinning scrollbars, right?  The main benefit of thinning scrollbars today is mousemove-based activation, but this could be implemented onto the Android style ones as well.  The thinning itself seems like an arbitrary difference.

Comment 5 by bokan@chromium.org, Sep 23 2016

Cc: dk...@chromium.org tbuck...@chromium.org tdres...@chromium.org
That's a good point; I think it's likely we'd eventually want to unify the two anyway. +tbuckley@ and dknox@ who are PM'ing the feature (I think). Has this been given any thought before?
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38991f06ebb579440a3bf3f3fbb8792a60b610d4

commit 38991f06ebb579440a3bf3f3fbb8792a60b610d4
Author: sahel <sahel@chromium.org>
Date: Thu Sep 29 19:56:14 2016

Overlay scrollbars are painted onload.

I fixed the AdjustScale function to keep the values within a valid range. Now, when it is called during LayerImpl::PushPropertiesTo, the temporarily invalid scrollbar->Opacity() doesn't set the opacity to zero.

The tests fails before applying this patch, and passes on this patch.

BUG= 635629 
TEST=ScrollbarAnimationControllerThinningTest.AppearOnResize
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2345823003
Cr-Commit-Position: refs/heads/master@{#421910}

[modify] https://crrev.com/38991f06ebb579440a3bf3f3fbb8792a60b610d4/cc/input/scrollbar_animation_controller_thinning.cc
[modify] https://crrev.com/38991f06ebb579440a3bf3f3fbb8792a60b610d4/cc/input/scrollbar_animation_controller_thinning.h
[modify] https://crrev.com/38991f06ebb579440a3bf3f3fbb8792a60b610d4/cc/input/scrollbar_animation_controller_thinning_unittest.cc

Comment 7 by sahel@chromium.org, Sep 30 2016

Status: Fixed (was: Started)

Sign in to add a comment