New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635618 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

testDestroyUploadDataStreamAdapterOnSucceededCallback flaky on L bot

Project Member Reported by mge...@chromium.org, Aug 8 2016 
Run with flake: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder/builds/105

C  196.464s Main  [FAIL] org.chromium.net.CronetUrlRequestTest#testDestroyUploadDataStreamAdapterOnSucceededCallback:
C  196.464s Main  java.lang.IllegalStateException: Cannot shutdown with active requests.
C  196.464s Main  	at org.chromium.net.impl.CronetUrlRequestContext.shutdown(CronetUrlRequestContext.java:202)
C  196.464s Main  	at org.chromium.net.CronetUrlRequestTest.tearDown(CronetUrlRequestTest.java:54)
C  196.464s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  196.464s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  196.464s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  196.464s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Comment 2 by xunji...@chromium.org, Aug 15 2016

Owner: xunji...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3374c6c22d11e179773fbf1a89673f7e0a362e1

commit a3374c6c22d11e179773fbf1a89673f7e0a362e1
Author: xunjieli <xunjieli@chromium.org>
Date: Mon Aug 15 18:39:15 2016

[Cronet] Fix testDestroyUploadDataStreamAdapterOnSucceededCallback flake.

This CL makes testDestroyUploadDataStreamAdapterOnSucceededCallback to
wait until the request finishes, so tearDown() can safely shut down the
CronetEngine.

BUG= 635618 

Review-Url: https://codereview.chromium.org/2247773002
Cr-Commit-Position: refs/heads/master@{#411999}

[modify] https://crrev.com/a3374c6c22d11e179773fbf1a89673f7e0a362e1/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Comment 4 by xunji...@chromium.org, Aug 15 2016

Status: Fixed (was: Assigned)
Hopefully it's fixed!
►

Sign in to add a comment