New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635596 link

Starred by 4 users
Status: Fixed
Owner:
panicker@chromium.org
Closed: Feb 2017
Cc:
█ ahbeng@chromium.org
igrigo...@chromium.org
█ nduca@chromium.org
panicker@chromium.org
yoavweiss@chromium.org
npm@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 651461
issue 658030
issue 667007
issue 667581
issue 671367
issue 671727
issue 676484


Sign in to add a comment

Implement Long Task Notifications in Performance Observer

Project Member Reported by panicker@chromium.org, Aug 8 2016 
Feature description:
API to enable applications to detect presence of “long tasks” that monopolize the UI thread for extended periods of time and block other critical tasks from being executed - e.g. reacting to user input.

Eng owner: panicker@google.com

Design doc: http://go/longtasks

Changes to API surface:
* new interface: PerformanceLongTaskTiming (type of PerformanceEntry)

Links:
* https://github.com/spanicker/longtasks
* https://discourse.wicg.io/t/proposal-long-task-notifications-in-performance-observer/1613

Comment 1 by panicker@chromium.org, Aug 8 2016

Summary: Implement Long Task Notifications in Performance Observer (was: Long Task Notifications in Performance Observer)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67ecd9023c61fcf77899dbeca071f5f35aabb8f0

commit 67ecd9023c61fcf77899dbeca071f5f35aabb8f0
Author: panicker <panicker@chromium.org>
Date: Thu Aug 25 02:17:11 2016

LongTaskTiming: add idl, Experiment flag, PerformanceEntry and basic implementation

BUG= 635596 

Review-Url: https://codereview.chromium.org/2244813002
Cr-Commit-Position: refs/heads/master@{#414257}

[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/fast/dom/Window/window-properties-performance-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/Performance.idl
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceEntry.h
[add] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
[add] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
[add] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl
[modify] https://crrev.com/67ecd9023c61fcf77899dbeca071f5f35aabb8f0/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 4 by igrigo...@chromium.org, Aug 25 2016 

(snip)
 80 [RuntimeEnabled=LongTaskObserver] void clearLongTaskTimings();
 81 [RuntimeEnabled=LongTaskObserver] void setLongTaskTimingBufferSize(unsigned 
    long maxSize);
 82 [RuntimeEnabled=LongTaskObserver] attribute EventHandler onlongtasktimingbuf
    ferfull;

Why did we even add these? If we're only planning to these events via PerfObserver, all of the above should be unnecessary + related methods to append to buffer, etc.

Comment 5 by panicker@google.com, Aug 25 2016 

Ok thanks, I was a bit confused about that and should have asked.
Will remove in follow up CL.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9caeb1b95bbdfab5aa7688e6ce143f018f58178

commit d9caeb1b95bbdfab5aa7688e6ce143f018f58178
Author: panicker <panicker@chromium.org>
Date: Tue Aug 30 03:41:19 2016

Generalize TaskTimeTracker interface and expose WebThread. This is now used by InspectorWebPerfAgent for Long Task Observer.

BUG= 635596 

Review-Url: https://codereview.chromium.org/2259013003
Cr-Commit-Position: refs/heads/master@{#415051}

[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/blink_platform.gypi
[delete] https://crrev.com/6d8fdaabe1a8faed9a5573047a2cebdd8456a996/third_party/WebKit/Source/platform/scheduler/base/long_task_tracker.cc
[delete] https://crrev.com/6d8fdaabe1a8faed9a5573047a2cebdd8456a996/third_party/WebKit/Source/platform/scheduler/base/long_task_tracker.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[delete] https://crrev.com/6d8fdaabe1a8faed9a5573047a2cebdd8456a996/third_party/WebKit/Source/platform/scheduler/base/task_time_tracker.h
[rename] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/base/test_task_time_observer.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/public/platform/WebThread.h
[add] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/public/platform/scheduler/base/task_time_observer.h
[modify] https://crrev.com/d9caeb1b95bbdfab5aa7688e6ce143f018f58178/third_party/WebKit/public/platform/scheduler/child/webthread_base.h

Comment 7 by ahbeng@chromium.org, Sep 8 2016

Cc: ahbeng@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57340e50c3c836cad45b2c88e3903ee8f68010b9

commit 57340e50c3c836cad45b2c88e3903ee8f68010b9
Author: msw <msw@chromium.org>
Date: Thu Sep 15 19:45:13 2016

Revert of Track frame context URL using first script heuristic (patchset #7 id:120001 of https://codereview.chromium.org/2296923004/ )

Reason for revert:
broke compile:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/93915
c:\b\c\b\win_layout\src\third_party\webkit\source\core\inspector\inspectorwebperfagenttest.cpp(48) : error C2220: warning treated as error - no 'object' file generated
c:\b\c\b\win_layout\src\third_party\webkit\source\core\inspector\inspectorwebperfagenttest.cpp(48) : warning C4702: unreachable code

Original issue's description:
> Track frame context URL using first script heuristic
>
> BUG= 635596 
>
> Committed: https://crrev.com/7012b38dafd3fcaaeaee7b7413718b4b6d7493ca
> Cr-Commit-Position: refs/heads/master@{#418931}

TBR=caseq@chromium.org,alph@chromium.org,pfeldman@chromium.org,dgozman@chromium.org,panicker@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 635596 

Review-Url: https://codereview.chromium.org/2345023002
Cr-Commit-Position: refs/heads/master@{#418933}

[modify] https://crrev.com/57340e50c3c836cad45b2c88e3903ee8f68010b9/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/57340e50c3c836cad45b2c88e3903ee8f68010b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
[modify] https://crrev.com/57340e50c3c836cad45b2c88e3903ee8f68010b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
[delete] https://crrev.com/6366cd9b50e811aa474c1a3a1910f2d0c1d15c06/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2240ff457a2512b5868aa923f56bab1cd9bb4a

commit ad2240ff457a2512b5868aa923f56bab1cd9bb4a
Author: panicker <panicker@chromium.org>
Date: Tue Sep 20 13:48:25 2016

enable / disable Long Task instrumentation based on presence of LongTask observer

BUG= 635596 

Review-Url: https://codereview.chromium.org/2343553005
Cr-Commit-Position: refs/heads/master@{#419743}

[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/timing/Performance.h
[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[add] https://crrev.com/ad2240ff457a2512b5868aa923f56bab1cd9bb4a/third_party/WebKit/Source/core/timing/PerformanceTest.cpp

Comment 13 by panicker@chromium.org, Sep 29 2016

Blockedon: 651461
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9

commit d4b3a10ae0b35dc3f40c966a139f30127c29c1b9
Author: panicker <panicker@chromium.org>
Date: Wed Oct 05 20:18:43 2016

Pass DOMWinow to PerformanceLongTaskTiming for attribution
Handle cross-origin attribution.

BUG= 635596 

Review-Url: https://codereview.chromium.org/2386403002
Cr-Commit-Position: refs/heads/master@{#423271}

[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb97c0221783a1524b0507d66009eedda5fced27

commit cb97c0221783a1524b0507d66009eedda5fced27
Author: panicker <panicker@chromium.org>
Date: Wed Oct 05 22:48:14 2016

Remove buffering from PerformanceLongTaskTiming as it's not in the spec.
PerformanceLongTaskTiming will only be supported via PerformanceObserver callbacks.

BUG= 635596 

Review-Url: https://codereview.chromium.org/2395653002
Cr-Commit-Position: refs/heads/master@{#423323}

[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/window-properties-performance-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/Performance.idl
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceObserver.h
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97baf8674918865d98af196ee9f9dcf0a3a4fd8c

commit 97baf8674918865d98af196ee9f9dcf0a3a4fd8c
Author: panicker <panicker@chromium.org>
Date: Wed Oct 19 01:38:03 2016

Add a layout test for longtask timing

BUG= 635596 

Review-Url: https://chromiumcodereview.appspot.com/2422433002
Cr-Commit-Position: refs/heads/master@{#426108}

[add] https://crrev.com/97baf8674918865d98af196ee9f9dcf0a3a4fd8c/third_party/WebKit/LayoutTests/fast/performance/longtasktiming.html

Comment 20 by panicker@google.com, Oct 20 2016

Blockedon: 658030
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9

commit d4b3a10ae0b35dc3f40c966a139f30127c29c1b9
Author: panicker <panicker@chromium.org>
Date: Wed Oct 05 20:18:43 2016

Pass DOMWinow to PerformanceLongTaskTiming for attribution
Handle cross-origin attribution.

BUG= 635596 

Review-Url: https://codereview.chromium.org/2386403002
Cr-Commit-Position: refs/heads/master@{#423271}

[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
[modify] https://crrev.com/d4b3a10ae0b35dc3f40c966a139f30127c29c1b9/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb97c0221783a1524b0507d66009eedda5fced27

commit cb97c0221783a1524b0507d66009eedda5fced27
Author: panicker <panicker@chromium.org>
Date: Wed Oct 05 22:48:14 2016

Remove buffering from PerformanceLongTaskTiming as it's not in the spec.
PerformanceLongTaskTiming will only be supported via PerformanceObserver callbacks.

BUG= 635596 

Review-Url: https://codereview.chromium.org/2395653002
Cr-Commit-Position: refs/heads/master@{#423323}

[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/fast/dom/Window/window-properties-performance-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/Performance.idl
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/cb97c0221783a1524b0507d66009eedda5fced27/third_party/WebKit/Source/core/timing/PerformanceObserver.h
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4a2d76b144acd15b8600162950e973965ababb9

commit e4a2d76b144acd15b8600162950e973965ababb9
Author: panicker <panicker@chromium.org>
Date: Tue Nov 01 23:17:29 2016

Refactor InspectorWebPerfAgent: update lifecycle management to be per Local Frame root; replace heapset of locations with frames.

BUG= 635596 

Review-Url: https://codereview.chromium.org/2449673002
Cr-Commit-Position: refs/heads/master@{#429149}

[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/timing/Performance.h
[modify] https://crrev.com/e4a2d76b144acd15b8600162950e973965ababb9/third_party/WebKit/Source/core/timing/PerformanceTest.cpp

Comment 24 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 25 by panicker@chromium.org, Nov 19 2016

Blockedon: 667007

Comment 26 by panicker@chromium.org, Nov 22 2016

Blockedon: 667581

Comment 27 by panicker@chromium.org, Dec 5 2016

Blockedon: 671367

Comment 28 by panicker@chromium.org, Dec 6 2016

Blockedon: 671727

Comment 29 by panicker@chromium.org, Dec 21 2016

Blockedon: 676484

Comment 30 by panicker@chromium.org, Feb 4 2017

Status: Fixed (was: Assigned)
Closing this bug, let's track specific issues as separate bugs.

Comment 31 by panicker@chromium.org, Feb 4 2017 

For folks interested in tracking progress feel free to cc yourself on:
 https://crbug.com/688439
►

Sign in to add a comment