New issue
Advanced search Search tips

Issue 635590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

media controls should use margin when computing what fits

Project Member Reported by liber...@chromium.org, Aug 8 2016

Issue description

<b>Version: <Kenneth, what is the frequency?></b>
<b>OS: <please tell me it's not XP></b>

What steps will reproduce the problem?
(1) https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
(2) set width to 140
(3) observe that the full screen button is not entirely visible

i've seen this issue before and forgot to write it up.  in MediaControls::computeWhichControlsFit, it ignores the 18px margin that the sliders have.

it should really pay attention to margin of all the controls.  it's probably also a good idea to make the algorithm stop adding lower priority controls once a higher-priority one is dropped.  otherwise, it looks weird as controls appear then disappear as the bar gets wider.  right now, the controls are all the same width so this never happens.

 
Components: Blink>Media>Controls
Labels: Needs-BlinkMediaTriage
Cc: -mlamouri@chromium.org
Labels: -Needs-BlinkMediaTriage
Owner: mlamouri@chromium.org
Status: Fixed (was: Available)
That has been fixed in latest Beta.

Sign in to add a comment