New issue
Advanced search Search tips

Issue 635588 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

crosperf: could not show results.

Project Member Reported by yunlian@chromium.org, Aug 8 2016

Issue description


The output of crosperf looks like
Summary
-------------------------------------------
Benchmark:  dromaeo.domcoremodify;  Iterations: 3 
   keys vanilla_image  (pass:0 fail:3)             nonafdo_image  (pass:0 fail:3)         llvm_trybot_image  (pass:0 fail:3) 
   Keys Amean  StdDev StdDev/Mean GmeanSpeedup p-value Amean  StdDev StdDev/Mean GmeanSpeedup p-value Amean  StdDev StdDev/Mean GmeanSpeedup p-value 
Results   Fail      ?           ?                        Fail      ?           ?                        Fail      ?           ?          

 vanilla_image: dromaeo.domcoremodify (1) SUCCEEDED                
           vanilla_image: dromaeo.domcoremodify (2) SUCCEEDED                
           vanilla_image: dromaeo.domcoremodify (3) SUCCEEDED                

It shows the tests failed in the result but it shows they run successful in the summary.
 
Labels: -Pri-3 Pri-1
Owner: cmt...@chromium.org
Status: Assigned (was: Untriaged)
The problem seems to be that when the telemetry tests are run locally rather than remotely, telemetry_Crosperf is not retrieving the json results file.  I'm in the process of fixing that now.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bcf13d8ebbfb09634439cced6e482d354b9f4a7c

commit bcf13d8ebbfb09634439cced6e482d354b9f4a7c
Author: Caroline Tice <cmtice@google.com>
Date: Wed Aug 10 21:44:48 2016

[autotest] Fix telemetry_Crosperf to scp results from dut.

telemetry_Crosperf is not copying the results-chart.json file (from
either the dut (when run_local=True) or from the chrome src tree within
the chroot) into the test_that results directoy.  This CL fixes that.
It also removes the code for parsing the results from stdout, since
telemetry no longer puts them there. It also ensures telemetry is called
with --output-format=chartjson.

BUG= chromium:635588 
TEST=Tested with test_that and crosperf.

Change-Id: I97bdad65a0ab4bf7a34bd7d0154eedd90507c8b6
Reviewed-on: https://chromium-review.googlesource.com/367808
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/bcf13d8ebbfb09634439cced6e482d354b9f4a7c/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bcf13d8ebbfb09634439cced6e482d354b9f4a7c

commit bcf13d8ebbfb09634439cced6e482d354b9f4a7c
Author: Caroline Tice <cmtice@google.com>
Date: Wed Aug 10 21:44:48 2016

[autotest] Fix telemetry_Crosperf to scp results from dut.

telemetry_Crosperf is not copying the results-chart.json file (from
either the dut (when run_local=True) or from the chrome src tree within
the chroot) into the test_that results directoy.  This CL fixes that.
It also removes the code for parsing the results from stdout, since
telemetry no longer puts them there. It also ensures telemetry is called
with --output-format=chartjson.

BUG= chromium:635588 
TEST=Tested with test_that and crosperf.

Change-Id: I97bdad65a0ab4bf7a34bd7d0154eedd90507c8b6
Reviewed-on: https://chromium-review.googlesource.com/367808
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/bcf13d8ebbfb09634439cced6e482d354b9f4a7c/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py

Comment 4 by cmt...@chromium.org, Aug 15 2016

Status: Fixed (was: Assigned)

Comment 5 by vapier@chromium.org, Aug 15 2016

Status: Assigned (was: Fixed)
there's one or two bugs in that CL that need fixing
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/db23d7aae74ac1e8b4e3e2b82303bee2241de949

commit db23d7aae74ac1e8b4e3e2b82303bee2241de949
Author: Caroline Tice <cmtice@google.com>
Date: Tue Aug 16 16:51:17 2016

[telemetry_Crosperf] Fix minor issues.

This CL addresses a few minor issues posted in a previous CL after
the previous CL had been approved and submitted.  For reference
the previous CL is
https://chromium-review.googlesource.com/#/c/367808

BUG= chromium:635588 
TEST=Tested with test_that inside chroot.

Change-Id: I77c28aac6efbb337eb507ebf90c9a9e9abeaa4cf
Reviewed-on: https://chromium-review.googlesource.com/371060
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/db23d7aae74ac1e8b4e3e2b82303bee2241de949/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py

Comment 7 by cmt...@chromium.org, Aug 17 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 9 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 10 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment