Fullscreen button should have highest priority in media controls |
||||||
Issue descriptionSTR: 1. Load https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html 2. Reduce width until you see only two buttons (~100px) Expected result: you see Play and Fullscreen buttons. Actual result: you see Play and CC buttons. CC: rachelis@ and liberato@ in case of they have background on this (ie. is this intentional?)
,
Aug 9 2016
That was my rationale, and sorry for not explaining it: fullscreen is one of the most used button after play/pause and it will offer the ability to the user to actually see more buttons so better to show it. Note that this issue might becomes moot with the responsive controls.
,
Aug 9 2016
,
Aug 9 2016
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16042098554782522c2847df7d449f3db6a1dcce commit 16042098554782522c2847df7d449f3db6a1dcce Author: kdsilva <kdsilva@google.com> Date: Wed Aug 17 13:47:45 2016 Updating media controls to give fullscreen button highest priority BUG= 635581 Review-Url: https://codereview.chromium.org/2222163005 Cr-Commit-Position: refs/heads/master@{#412513} [add] https://crrev.com/16042098554782522c2847df7d449f3db6a1dcce/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html [modify] https://crrev.com/16042098554782522c2847df7d449f3db6a1dcce/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/16042098554782522c2847df7d449f3db6a1dcce/third_party/WebKit/LayoutTests/media/video-controls-fullscreen.js [modify] https://crrev.com/16042098554782522c2847df7d449f3db6a1dcce/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
,
Aug 17 2016
,
Aug 19 2016
Tested the issue on Windows 7, Mac 10.11.6, Ubuntu 14.04 using 54.0.2832.2.Able to see Play and Fullscreen buttons when we reduce width until we see only two buttons. Please find attached screenshot. Marking it as TE-Verified. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by liber...@chromium.org
, Aug 8 2016