New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635567 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
agrieve@chromium.org
pkotw...@chromium.org
█ wnwen@chromium.org
estevenson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocked on:
issue 672490
issue 669629
issue 717473
Blocking:
issue 715196
issue 607761



Sign in to add a comment

Address lint warnings suppressed in build/android/lint/suppressions.xml

Project Member Reported by estevenson@chromium.org, Aug 8 2016 
Tracking bug for android lint warnings.

In  http://crbug.com/607761 , we made GN fail builds when lint warnings exist. And in http://crbug.com/669999, lint is updated. However, we suppressed all existing lint warnings to do so, and many of these lint warnings should still be addressed.

Description of the lint errors: http://tools.android.com/tips/lint-checks
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f84bc5b28466ff39c7b34320d357a430bb1e6631

commit f84bc5b28466ff39c7b34320d357a430bb1e6631
Author: estevenson <estevenson@chromium.org>
Date: Tue Aug 09 14:38:43 2016

Suppress ValidFragment warning for non default fragment constructor.

The non default constructor was added for https://crbug.com/618993.

BUG=635567

Review-Url: https://codereview.chromium.org/2225983002
Cr-Commit-Position: refs/heads/master@{#410666}

[modify] https://crrev.com/f84bc5b28466ff39c7b34320d357a430bb1e6631/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteChooserDialogFactory.java
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/8700776b7a84e4d400c5c8feebac7e1d6c291197

commit 8700776b7a84e4d400c5c8feebac7e1d6c291197
Author: Eric Stevenson <estevenson@google.com>
Date: Tue Aug 23 21:22:51 2016

Comment 4 by estevenson@chromium.org, Sep 9 2016

Description: Show this description

Comment 6 by dgn@chromium.org, Oct 6 2016

Description: Show this description

Comment 7 by estevenson@chromium.org, Oct 25 2016

Summary: Address lint warnings suppressed in build/android/lint/suppressions.xml (was: Address several lint warnings)

Comment 8 by pkotw...@chromium.org, Nov 3 2016

Cc: pkotw...@chromium.org

Comment 9 by sanfin@chromium.org, Nov 29 2016

Blockedon: 669629

Comment 10 by dgn@chromium.org, Dec 8 2016

Blockedon: 672490
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d3d021829cb0df282840aab35f06b46598ad935

commit 6d3d021829cb0df282840aab35f06b46598ad935
Author: estevenson <estevenson@chromium.org>
Date: Wed Feb 22 23:36:14 2017

Android: address lint warnings.

All suppressed lint warnings should have a comment explaining why they
are necessary. This CL also removes suppressions that were fixed in
https://codereview.chromium.org/2327833002/.

BUG=635567

Review-Url: https://codereview.chromium.org/2707973007
Cr-Commit-Position: refs/heads/master@{#452273}

[modify] https://crrev.com/6d3d021829cb0df282840aab35f06b46598ad935/build/android/lint/suppressions.xml
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d07ac83d22d93a9b7eee74b2d9a459303108aad

commit 6d07ac83d22d93a9b7eee74b2d9a459303108aad
Author: bsazonov <bsazonov@chromium.org>
Date: Wed Mar 22 18:29:21 2017

Added missing case to the switch and removed lint suppression

This CL makes lint happy by handling all possible IntDef values in the switch.

BUG=635567

Review-Url: https://codereview.chromium.org/2763223004
Cr-Commit-Position: refs/heads/master@{#458812}

[modify] https://crrev.com/6d07ac83d22d93a9b7eee74b2d9a459303108aad/chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/749433b28d0875dfce9194211f6345f45fa6cea5

commit 749433b28d0875dfce9194211f6345f45fa6cea5
Author: awdf <awdf@chromium.org>
Date: Mon Mar 27 12:54:12 2017

Android: Check intent action in broadcast receiver for package replaced

- no longer need to suppress lint

BUG=635567

Review-Url: https://codereview.chromium.org/2778763002
Cr-Commit-Position: refs/heads/master@{#459763}

[modify] https://crrev.com/749433b28d0875dfce9194211f6345f45fa6cea5/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java

Comment 14 by zpeng@chromium.org, Apr 19 2017

Description: Show this description

Comment 15 by zpeng@chromium.org, Apr 25 2017

Blocking: 715196
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/ae1e4daf648ca732155669281c837529b93d145e

commit ae1e4daf648ca732155669281c837529b93d145e
Author: F <zpeng@chromium.org>
Date: Wed Apr 26 19:14:17 2017
Project Member

Comment 17 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d

commit 5512e732f9513b2e5b3f8c47f146dfa5c3582b6d
Author: zpeng <zpeng@chromium.org>
Date: Tue May 02 03:18:09 2017

Update to newer Android Lint and suppress new Lint errors

This CL updates DEPS to enable updated Android Lint that would work for
Java 8. Also, it adds inline suppression for newly discovered Lint
errors. Additionally, it suppresses Lint deprecation warning for
"android:singleLine". Moreover, it suppresses Lint warnings "AuthLeak",
"VisibleForTests", etc. for tests, and Lint error "ByteOrderMark" in
generated android_chrome_strings.xml (crbug.com/715196).

BUG=635567,669999

Review-Url: https://codereview.chromium.org/2830843004
Cr-Commit-Position: refs/heads/master@{#468545}

[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewCreateDestroyActivity.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/base/android/java/src/org/chromium/base/ApplicationStatus.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/build/android/lint/suppressions.xml
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/build/config/android/internal_rules.gni
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/accessibility/FontSizePrefs.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadRetry.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAState.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapterService.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/payments/PackageManagerDelegate.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/tab/TabIdManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/tab/TabStateBrowserControlsVisibilityDelegate.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/test/android/cast_emulator/src/org/chromium/chrome/browser/media/remote/RemoteSessionManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastSysInfoAndroid.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/device/usb/android/java/src/org/chromium/device/usb/ChromeUsbInterface.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/ui/android/java/src/org/chromium/ui/base/Clipboard.java
[modify] https://crrev.com/5512e732f9513b2e5b3f8c47f146dfa5c3582b6d/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java

Comment 18 by dgn@chromium.org, May 2 2017

Blockedon: 717473
Project Member

Comment 19 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/268bd8b3738aa5e18df731c881893a797032b37b

commit 268bd8b3738aa5e18df731c881893a797032b37b
Author: reillyg <reillyg@chromium.org>
Date: Wed May 03 01:53:00 2017

Remove redundant static singleton for DeviceSensors

The singleton Java DeviceSensors object is owned by a singleton
SensorManagerAndroid so there is no need to maintain a reference to the
singleton in both Java and C++. This silences the lint warning about
keeping references to the Context object in a static field because now
the static field is in C++ and thus invisible to the linter.

BUG=635567

Review-Url: https://codereview.chromium.org/2860633003
Cr-Commit-Position: refs/heads/master@{#468863}

[modify] https://crrev.com/268bd8b3738aa5e18df731c881893a797032b37b/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java
[modify] https://crrev.com/268bd8b3738aa5e18df731c881893a797032b37b/device/sensors/sensor_manager_android.cc
Project Member

Comment 20 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50836ea0c36923be03cbb2dcb4d80a59644b3912

commit 50836ea0c36923be03cbb2dcb4d80a59644b3912
Author: reillyg <reillyg@chromium.org>
Date: Wed May 03 01:54:35 2017

Move @TargetApi annotation to AndroidBatteryManagerWrapper

BatteryStatusManager.updateBatteryStatusForLollipop only calls the
Android L+ API BatteryManager.getIntProperty through
AndroidBatteryManagerWrapper so this annotation should be moved there.

BUG=635567

Review-Url: https://codereview.chromium.org/2858823002
Cr-Commit-Position: refs/heads/master@{#468865}

[modify] https://crrev.com/50836ea0c36923be03cbb2dcb4d80a59644b3912/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
Project Member

Comment 21 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8bfab30bb6ee9f95277a16ee02bc930da2b2a2a

commit f8bfab30bb6ee9f95277a16ee02bc930da2b2a2a
Author: reillyg <reillyg@chromium.org>
Date: Wed May 03 01:58:44 2017

Add @TargetApi annotation to ChromeUsbInterface.getAlternateSetting

This annotation was missing. The native side only calls this method if
the API version is greater than or equal to 21 (Lolipop).

BUG=635567

Review-Url: https://codereview.chromium.org/2857663003
Cr-Commit-Position: refs/heads/master@{#468869}

[modify] https://crrev.com/f8bfab30bb6ee9f95277a16ee02bc930da2b2a2a/device/usb/android/java/src/org/chromium/device/usb/ChromeUsbInterface.java
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4

commit 3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4
Author: bsazonov <bsazonov@chromium.org>
Date: Fri Jun 02 18:01:14 2017

Replace lint suppressions for vector drawables with targetApi attribute

Vector drawables without targetApi attribute cause lint error when target API
is less than 21.

BUG=635567

Review-Url: https://codereview.chromium.org/2921003002
Cr-Commit-Position: refs/heads/master@{#476717}

[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/build/android/lint/suppressions.xml
[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/chrome/android/java/res/drawable/downloads_big.xml
[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/chrome/android/java/res/drawable/ic_bluetooth_connected.xml
[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml
[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/chrome/android/java/res/drawable/ic_signal_cellular_1_bar.xml
[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/chrome/android/java/res/drawable/ic_signal_cellular_2_bar.xml
[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/chrome/android/java/res/drawable/ic_signal_cellular_3_bar.xml
[modify] https://crrev.com/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4/chrome/android/java/res/drawable/ic_signal_cellular_4_bar.xml

Comment 23 by wnwen@chromium.org, Jun 8 2017

Cc: wnwen@chromium.org
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb15587b30605733e33eb3bcfae1d889aacb17dc

commit bb15587b30605733e33eb3bcfae1d889aacb17dc
Author: Donn Denman <donnd@chromium.org>
Date: Thu Jun 14 23:51:02 2018

[TTS] Cleanup in ContextualSearchManager.java.

Minor cleanup of stale TODOs and other cruft in
ContextualSearchManager.java.

BUG=635567, 607127

Change-Id: If71b43ef07f0e2aaaa581b9481765b6ae551d315
Reviewed-on: https://chromium-review.googlesource.com/1100976
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567486}
[modify] https://crrev.com/bb15587b30605733e33eb3bcfae1d889aacb17dc/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Comment 25 by estevenson@chromium.org, Sep 28

Cc: estevenson@chromium.org
Owner: ----
I don't plan on working on this further (it might make more sense to just close this one).

Comment 26 by estevenson@chromium.org, Sep 28

Status: Available (was: Assigned)

Comment 27 by wnwen@chromium.org, Oct 1

Labels: Type-Task
Changed type to task instead of bug.

Comment 28 by wnwen@chromium.org, Oct 1

Components: Build

Comment 29 by agrieve@chromium.org, Jan 11

Labels: DevX
►

Sign in to add a comment