New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635566 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ARC custom notification improvments

Project Member Reported by xiy...@chromium.org, Aug 8 2016

Issue description

Tracking bug for the following:
- Keyboard dismissal (minimum support for b/30575694);
- Swipe to dimiss (b/30575771);
- Showing close button only when mouse hover (needed by b/30506701)

 

Comment 1 by xiy...@chromium.org, Aug 10 2016

One more case to verify that clicking on closing button should not crash. (b/30768240).
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/416f1f674c873e3b58963e64a2ef01e52dcfbe5e

commit 416f1f674c873e3b58963e64a2ef01e52dcfbe5e
Author: xiyuan <xiyuan@chromium.org>
Date: Thu Aug 11 05:21:12 2016

arc: Custom notification improvements

- Install a pre target event handler to notification surface window
  to forward events to hosting ArcCustomNotificationView;
- Only show close button when mouse hovering;
- Add SlideHelper to observe slide transform/animation and swap between
  a notification surface copy and real surface when a slide starts/stops;

BUG= 635566 ,636625
TEST=Manual. Close button only shows up when mouse hovering. Backspace/delete
  key dismisses the custom notification. Swipe gesture works as regular
  Chrome notification. Closing via close button in message list does not crash.

Review-Url: https://codereview.chromium.org/2221073002
Cr-Commit-Position: refs/heads/master@{#411272}

[modify] https://crrev.com/416f1f674c873e3b58963e64a2ef01e52dcfbe5e/ui/arc/BUILD.gn
[modify] https://crrev.com/416f1f674c873e3b58963e64a2ef01e52dcfbe5e/ui/arc/arc.gyp
[modify] https://crrev.com/416f1f674c873e3b58963e64a2ef01e52dcfbe5e/ui/arc/notification/DEPS
[modify] https://crrev.com/416f1f674c873e3b58963e64a2ef01e52dcfbe5e/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/416f1f674c873e3b58963e64a2ef01e52dcfbe5e/ui/arc/notification/arc_custom_notification_view.h

Comment 3 by xiy...@chromium.org, Aug 11 2016

Merge to M53 is requested on issue 636625.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 15 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04d983055adc49b17a9e6a4c08b03104c1453098

commit 04d983055adc49b17a9e6a4c08b03104c1453098
Author: Xiyuan Xia <xiyuan@google.com>
Date: Mon Aug 15 17:42:29 2016

Merge "arc: Custom notification improvements"

> - Install a pre target event handler to notification surface window
>   to forward events to hosting ArcCustomNotificationView;
> - Only show close button when mouse hovering;
> - Add SlideHelper to observe slide transform/animation and swap between
>   a notification surface copy and real surface when a slide starts/stops;
>
> BUG= 635566 ,636625
> TEST=Manual. Close button only shows up when mouse hovering. Backspace/delete
>   key dismisses the custom notification. Swipe gesture works as regular
>   Chrome notification. Closing via close button in message list does not crash.
>
> Review-Url: https://codereview.chromium.org/2221073002
> Cr-Commit-Position: refs/heads/master@{#411272}
> (cherry picked from commit 416f1f674c873e3b58963e64a2ef01e52dcfbe5e)

Review URL: https://codereview.chromium.org/2244333002 .

Cr-Commit-Position: refs/branch-heads/2785@{#592}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/04d983055adc49b17a9e6a4c08b03104c1453098/ui/arc/BUILD.gn
[modify] https://crrev.com/04d983055adc49b17a9e6a4c08b03104c1453098/ui/arc/arc.gyp
[modify] https://crrev.com/04d983055adc49b17a9e6a4c08b03104c1453098/ui/arc/notification/DEPS
[modify] https://crrev.com/04d983055adc49b17a9e6a4c08b03104c1453098/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/04d983055adc49b17a9e6a4c08b03104c1453098/ui/arc/notification/arc_custom_notification_view.h

Comment 5 by xiy...@chromium.org, Aug 15 2016

Labels: M-53
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
ChromeOS build 8530.96.0 / 53.0.2785.154

Sign in to add a comment