New issue
Advanced search Search tips

Issue 635560 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clearing DeviceMetricsOverride can lead to DCHECK failing

Project Member Reported by eseckler@chromium.org, Aug 8 2016

Issue description

The following DCHECK in RenderWidget::Resize() may fail after clearing the DeviceMetricsOverride:

DCHECK(!params.needs_resize_ack || !next_paint_is_resize_ack());

This is because the original ResizeParams are restored when the override is cleared, and those params may have needs_resize_ack set, even if there is already another resize in fly. Can be fixed by clearing the needs_resize_ack flag before restoring the params.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/722fb6bcbfc14db35e0b8a5546c9778827e7387c

commit 722fb6bcbfc14db35e0b8a5546c9778827e7387c
Author: eseckler <eseckler@chromium.org>
Date: Mon Aug 08 17:51:30 2016

Clear needs_resize_ack when clearing DeviceMetricsOverride.

BUG= 635560 

Review-Url: https://codereview.chromium.org/2228543002
Cr-Commit-Position: refs/heads/master@{#410389}

[modify] https://crrev.com/722fb6bcbfc14db35e0b8a5546c9778827e7387c/content/renderer/devtools/render_widget_screen_metrics_emulator.cc

Status: Fixed (was: Started)

Sign in to add a comment