Issue 635551 link

Starred by 1 user

Issue metadata

Status:	WontFix
Owner:	█ pdyson@chromium.org Last visit > 30 days ago
Closed:	Jan 2018
Cc:	yyushkina@chromium.org █ k...@chromium.org █ ainslie@chromium.org █ dfalcant...@chromium.org
Components:	UI>Browser>Language>Translate
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Bug

Split out Clank translate infobar metrics

Project Member Reported by zkoch@chromium.org, Aug 8 2016

Issue description

We currently have two different Translate infobars: the translation offered infobar and the "do you always|never want to do this" infobar. We'd like to separate these out for a better understanding of how they're being used. This has come up before, and I believe dan proposed the following:

To split the shown metrics, a histogram hook needs to be added to translate_infobar.cc::CreateRenderInfobar() that records delegate->translate_step() right before Java_TranslateInfoBar_show() is called.  Day or so to get histograms.xml reviewed.

Any way we could get this added?

Comment 1 by ainslie@chromium.org, Aug 8 2016

Cc: dfalcant...@chromium.org

+dfalcantara knows how to do this :) 
We talked about how to make infobar.shown more granular for translate a while back.

Comment 2 by dfalcant...@chromium.org, Aug 8 2016

First step is to find someone who has engineering cycles to implement it (shouldn't be too bad).

There are other translate infobar types you're missing.  I think the current set that is triggered via native looks like:
1) Do you want to translate this page? (Prompt)
2) This page is translating...         (Transient)
3) This page couldn't be translated    (Error, asks for retranslation)
4) This page was translated            (Yay)

Infobar #4 lets you select an option to always translate the language, which immediately skips 1, but has the potential to show 2, 3, and 4.

Infobar #1 lets you pick different languages to translate between by popping up a pseudo-infobar that isn't tracked by native.

The method Zach mentioned will likely work for identifying the differences between the real infobars (#1-4).  Alternatively, you could hook into here:
https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_infobar_delegate.cc?rcl=0&l=108