New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635549 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Move WebView.captureVisibleRegion to stable API.

Project Member Reported by wjmaclean@chromium.org, Aug 8 2016

Issue description

The captureVisibleRegion API for browser-tag WebView has been 'baking' since February, and to better support it's users should be promoted to stable channel.
 
Labels: M-53
Please provide CL as well and justification for merge. Thank you.
This has already landed in dev channel: https://codereview.chromium.org/2210333002/

We have consumers who need this in M53 in order to facilitate automating a workflow.
Since this is just making this feature available on stable, given it has been around for over 6 months, it should be a low-risk change.
Labels: -Merge-Request-53 Merge-Approved-53
Approving merge to M53 branch 2785 based on comment #2 and #3. Please merge today before 5:00 PT so we can take it for this week beta. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c506b58d64dd9ad1bd778db51ed8709ebf7a2d36

commit c506b58d64dd9ad1bd778db51ed8709ebf7a2d36
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Aug 08 19:37:58 2016

Move WebView.captureVisibleRegion to stable API.

WebView.captureVisibleRegion has been available in the experimental API
since 2016.02.01. It seems like it's time to make it available on the
stable channel.

BUG= 635549 

Review-Url: https://codereview.chromium.org/2210333002
Cr-Commit-Position: refs/heads/master@{#410154}
(cherry picked from commit 2b6427807476027a8b1e5fa2ee3036305a49d64e)

Review URL: https://codereview.chromium.org/2221143002 .

Cr-Commit-Position: refs/branch-heads/2785@{#532}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/c506b58d64dd9ad1bd778db51ed8709ebf7a2d36/extensions/common/api/_api_features.json
[modify] https://crrev.com/c506b58d64dd9ad1bd778db51ed8709ebf7a2d36/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/c506b58d64dd9ad1bd778db51ed8709ebf7a2d36/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/c506b58d64dd9ad1bd778db51ed8709ebf7a2d36/extensions/renderer/resources/guest_view/web_view/web_view.js
[modify] https://crrev.com/c506b58d64dd9ad1bd778db51ed8709ebf7a2d36/extensions/renderer/resources/guest_view/web_view/web_view_api_methods.js
[delete] https://crrev.com/2df48ee378d55469881502aff2690fd743d06d25/extensions/renderer/resources/guest_view/web_view/web_view_experimental.js

Status: Fixed (was: Started)
Labels: Merge-Request-52

Comment 8 by dimu@chromium.org, Aug 10 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M52), manual review required.
Cc: keta...@chromium.org tinazh@chromium.org gkihumba@chromium.org
Also requesting merge for M52 on desktop and ChromeOS.

Question for ChromeOS TPMs: Does the merge to 2785 automatically include ChromeOS? If not, it is possible to get it merged there too?

For Chrome Desktop, as of now there is no new  M52 release plan. If there is any,  we can take this change if it is well be baked in Beta.
Sure, that sounds good, thanks for the update!
Merge to 2785 chrome will be picked up by the next CROS 8530 build. It looks like this one is already merged to 2785. so we should be good for M53.

Sign in to add a comment