Add UMA logging in net::BidirectionalStream to track time to first byte, response end time, number of bytes received and number of bytes sent.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ff75c568c5feb797f1dd2dec7bd74577f8e0212 commit 9ff75c568c5feb797f1dd2dec7bd74577f8e0212 Author: xunjieli <xunjieli@chromium.org> Date: Wed Aug 10 20:26:16 2016 Remove net::BidirectionalStream::Cancel This CL removes the unused Cancel() method. This simplifies the interface, and make it easier to reason about, since there is one fewer state to worry about. BUG= 635548 Review-Url: https://codereview.chromium.org/2227083002 Cr-Commit-Position: refs/heads/master@{#411135} [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/http/bidirectional_stream.cc [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/http/bidirectional_stream.h [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/http/bidirectional_stream_impl.h [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/http/bidirectional_stream_unittest.cc [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/quic/chromium/bidirectional_stream_quic_impl.cc [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/quic/chromium/bidirectional_stream_quic_impl.h [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/spdy/bidirectional_stream_spdy_impl.cc [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/spdy/bidirectional_stream_spdy_impl.h [modify] https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212/net/spdy/bidirectional_stream_spdy_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d58621f529528a45a3f1f4309f9bc37a1e2005b8 commit d58621f529528a45a3f1f4309f9bc37a1e2005b8 Author: xunjieli <xunjieli@chromium.org> Date: Fri Aug 12 18:33:00 2016 Add UMA to net::BidirectionalStream Add UMA logging to track the following six metrics in net::BidirectionalStream: (1) time to reading first byte is allowed (2) time to reading last byte (3) time to sending first byte is allowed (4) time to sending last byte (5) number of bytes received (6) number of bytes sent BUG= 635548 Review-Url: https://codereview.chromium.org/2222113003 Cr-Commit-Position: refs/heads/master@{#411713} [modify] https://crrev.com/d58621f529528a45a3f1f4309f9bc37a1e2005b8/net/http/bidirectional_stream.cc [modify] https://crrev.com/d58621f529528a45a3f1f4309f9bc37a1e2005b8/net/http/bidirectional_stream.h [modify] https://crrev.com/d58621f529528a45a3f1f4309f9bc37a1e2005b8/tools/metrics/histograms/histograms.xml
Still need some work to fully support the Metrics API. Filed Issue 637051 separately for that.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eef1d9c826ac10c339518a86d47dfdcf8da7cec0 commit eef1d9c826ac10c339518a86d47dfdcf8da7cec0 Author: xunjieli <xunjieli@chromium.org> Date: Fri Sep 02 22:00:58 2016 Fix UMA logging for net::BidirectionalStream The CL fixes the UMA to use suffixes correctly. See crbug.com/643573 for more info. BUG= 635548 , 643573 Review-Url: https://codereview.chromium.org/2311433002 Cr-Commit-Position: refs/heads/master@{#416359} [modify] https://crrev.com/eef1d9c826ac10c339518a86d47dfdcf8da7cec0/net/http/bidirectional_stream.cc [modify] https://crrev.com/eef1d9c826ac10c339518a86d47dfdcf8da7cec0/tools/metrics/histograms/histograms.xml
Your change meets the bar and is auto-approved for M54 (branch: 2840)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a731b8734b0b46fb7114f4064d0f777243b41eb9 commit a731b8734b0b46fb7114f4064d0f777243b41eb9 Author: xunjieli <xunjieli@chromium.org> Date: Tue Sep 06 14:56:46 2016 Fix UMA logging for net::BidirectionalStream The CL fixes the UMA to use suffixes correctly. See crbug.com/643573 for more info. BUG= 635548 , 643573 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2311433002 Cr-Commit-Position: refs/heads/master@{#416359} (cherry picked from commit eef1d9c826ac10c339518a86d47dfdcf8da7cec0) Review-Url: https://codereview.chromium.org/2311793003 Cr-Commit-Position: refs/branch-heads/2840@{#169} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a731b8734b0b46fb7114f4064d0f777243b41eb9/net/http/bidirectional_stream.cc [modify] https://crrev.com/a731b8734b0b46fb7114f4064d0f777243b41eb9/tools/metrics/histograms/histograms.xml
Comment 1 by mef@chromium.org
, Aug 8 2016