New issue
Advanced search Search tips

Issue 635547 link

Starred by 1 user
Status: Fixed
Owner:
kojii@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

isUnambiguousHanScript DCHECK fails on wikipedia.org

Project Member Reported by smaier@chromium.org, Aug 8 2016 
To reproduce:
(1) Build and deploy debug ChromePublic.apk
(2) Navigate to wikipedia.org

What is the expected output?
Wikipedia loads normally

What do you see instead?
In adb logcat: [FATAL:LayoutLocale.cpp(80)] Check failed: isUnambiguousHanScript(m_scriptForHan). 

This was reproduced on Sprout device running L and a Hammerhead running N.

These lines appear to have been added recently - https://codereview.chromium.org/2192703002

Comment 1 by kojii@chromium.org, Aug 9 2016

Labels: -OS-Android -Pri-1 OS-All Pri-2
Status: Started (was: Assigned)
Thank you for finding this.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a03e3af96e1897c19e045842b8dd67b6eac3fa28

commit a03e3af96e1897c19e045842b8dd67b6eac3fa28
Author: kojii <kojii@chromium.org>
Date: Tue Aug 09 08:47:09 2016

Fix scriptCodeForHanFromSubtags() may return non-Han scripts

This patch fixes a regression caused by the refactoring[1] that
scriptCodeForHanFromSubtags() may return non-Han Ideographic scripts
by sharing the script data with scriptCodeForHanFromSubtags().

Also clean up #include of LocaleToScriptMapping.h that are no longer
used.

[1] https://codereview.chromium.org/2192703002

BUG= 635547 

Review-Url: https://codereview.chromium.org/2222283002
Cr-Commit-Position: refs/heads/master@{#410619}

[modify] https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28/third_party/WebKit/Source/platform/LayoutLocale.cpp
[modify] https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28/third_party/WebKit/Source/platform/LayoutLocaleTest.cpp
[modify] https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28/third_party/WebKit/Source/platform/fonts/FontDescription.h
[modify] https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28/third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp
[modify] https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28/third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp
[modify] https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28/third_party/WebKit/Source/platform/text/LocaleToScriptMapping.h

Comment 3 by kojii@chromium.org, Aug 9 2016

Status: Fixed (was: Started)
►

Sign in to add a comment