New issue
Advanced search Search tips

Issue 635536 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Handle non-launchable apps.

Project Member Reported by khmel@chromium.org, Aug 8 2016

Issue description

Inner bug: b/30508435


There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab

commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab
Author: khmel <khmel@chromium.org>
Date: Wed Aug 10 19:43:40 2016

arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG= 635536 
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test

Review-Url: https://codereview.chromium.org/2210143003
Cr-Commit-Position: refs/heads/master@{#411120}

[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/components/arc/common/app.mojom
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab/components/arc/test/fake_app_instance.h

Comment 2 by khmel@chromium.org, Aug 10 2016

Status: Fixed (was: Started)

Comment 3 by khmel@chromium.org, Aug 11 2016

Labels: OS-Chrome

Comment 4 by khmel@chromium.org, Aug 18 2016

Labels: Merge-Request-53
Status: Started (was: Fixed)
Android side change is in M53 already, this is Chrome side change. Requesting to merge 

Comment 5 by dimu@chromium.org, Aug 18 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27c8d0e766ad0550bd75e8a141818abbc7d46e9c

commit 27c8d0e766ad0550bd75e8a141818abbc7d46e9c
Author: khmel <khmel@chromium.org>
Date: Thu Aug 18 20:13:51 2016

arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG= 635536 
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2210143003
Cr-Commit-Position: refs/heads/master@{#411120}
(cherry picked from commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab)

Review-Url: https://codereview.chromium.org/2257923002
Cr-Commit-Position: refs/branch-heads/2785@{#664}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/components/arc/common/app.mojom
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/27c8d0e766ad0550bd75e8a141818abbc7d46e9c/components/arc/test/fake_app_instance.h

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589e1394d781695052ef0e75898d4bc2a1651157

commit 589e1394d781695052ef0e75898d4bc2a1651157
Author: khmel <khmel@chromium.org>
Date: Thu Aug 18 20:18:13 2016

Revert of arc: Handle non-launchable apps. (patchset #1 id:1 of https://codereview.chromium.org/2257923002/ )

Reason for revert:
Wrong resolve

Original issue's description:
> arc: Handle non-launchable apps.
>
> There are Android apps that can be started indirectly and which
> don't have launchable flag. We had no support such apps in Chrome
> and that caused incorrect behavior in shelf. Fix is to register
> such apps on creation with special flag that prevents them to
> appear in launcher app list and to be pinned in shelf.
>
> BUG= 635536 
> BUG=b/30508435
> TEST=Manually on device. Icon of an app (app info) appears on the
>      shelf and cannot be pinned. No app info icon in app list.
> TEST=Extended unit_test
> TBR=reviewer@chromium.org
> NOTRY=true
> NOPRESUBMIT=true
>
> Review-Url: https://codereview.chromium.org/2210143003
> Cr-Commit-Position: refs/heads/master@{#411120}
> (cherry picked from commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab)

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 635536 

Review-Url: https://codereview.chromium.org/2259033002
Cr-Commit-Position: refs/branch-heads/2785@{#666}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/components/arc/common/app.mojom
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/589e1394d781695052ef0e75898d4bc2a1651157/components/arc/test/fake_app_instance.h

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c

commit a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c
Author: khmel <khmel@chromium.org>
Date: Sun Aug 21 19:13:08 2016

arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG= 635536 
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2210143003
Cr-Commit-Position: refs/heads/master@{#411120}
(cherry picked from commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab)

Review-Url: https://codereview.chromium.org/2260363003
Cr-Commit-Position: refs/branch-heads/2785@{#696}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/components/arc/common/app.mojom
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/a4899b9c67f07b2ab4ecd93af4af0f3e9c690a3c/components/arc/test/fake_app_instance.h

Comment 9 by khmel@chromium.org, Aug 21 2016

Labels: -Hotlist-Merge-Approved Merge-Merged

Comment 10 by khmel@chromium.org, Aug 22 2016

Status: Fixed (was: Started)
Labels: VerifyIn-54
Status: Verified (was: Fixed)

Sign in to add a comment