New issue
Advanced search Search tips

Issue 635529 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

sizes step still broken after gn switch

Project Member Reported by thakis@chromium.org, Aug 8 2016

Issue description

https://build.chromium.org/p/chromium/builders/Mac/builds/18303/steps/sizes/logs/stdio

Running ['/usr/bin/python', u'/b/rr/tmpmO3Tpa/rw/checkout/scripts/tools/runit.py', '--show-path', '/usr/bin/python', u'/b/rr/tmpmO3Tpa/rw/checkout/scripts/slave/runtest.py', '--target', 'Release', '--xvfb', '--builder-name', u'Mac', '--slave-name', u'vm682-m1', '--build-number', '18303', '--build-properties', '{"buildnumber": 18303, "slavename": "vm682-m1", "target_platform": "mac", "mastername": "chromium", "buildername": "Mac"}', '--test-type', 'sizes', '--run-python-script', '/b/c/b/mac_ng/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py', '--json', '/tmp/tmpq6ODrW'] in None (env: None)
[Running on builder: "Mac"]

/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python /b/rr/tmpmO3Tpa/rw/checkout/scripts/slave/runisolatedtest.py --test_name sizes --builder_name Mac --checkout_dir /b/c/b/mac_ng /b/c/b/mac_ng/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py -- /System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python /b/c/b/mac_ng/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py --json /tmp/tmpq6ODrW

/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python /b/c/b/mac_ng/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py --json /tmp/tmpq6ODrW
 -- 
Warning: /usr/bin/atos is moving and will be removed from a future OS X release.
It is now available in the Xcode developer tools to be invoked via: `xcrun atos`
To silence this warning, pass the '-d' command-line flag to this tool.
 -- 
atos cannot load symbols for the file /b/c/b/mac_ng/src/out/Release/Chromium Framework.unstripped for architecture i386.
Traceback (most recent call last):
  File "/b/c/b/mac_ng/src/tools/mac/show_mod_init_func.py", line 73, in <module>
    sys.exit(Main())
  File "/b/c/b/mac_ng/src/tools/mac/show_mod_init_func.py", line 69, in Main
    ShowModuleInitializers(args[0])
  File "/b/c/b/mac_ng/src/tools/mac/show_mod_init_func.py", line 29, in ShowModuleInitializers
    symbols = SymbolizeAddresses(binary, initializers)
  File "/b/c/b/mac_ng/src/tools/mac/show_mod_init_func.py", line 58, in SymbolizeAddresses
    lines = subprocess.check_output(atos).strip().split('\n')
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 575, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['atos', '-o', '/b/c/b/mac_ng/src/out/Release/Chromium Framework.unstripped', '0x00000000013545e0', '0x000000000169f900', '0x00000000016cf7b0', '0x00000000016fac10', '0x0000000003967230', '0x0000000003968210', '0x000000000397c520', '0x000000000397f270', '0x0000000003980bf0', '0x00000000039827f0']' returned non-zero exit status 1

# Static initializers in /b/c/b/mac_ng/src/out/Release/Chromium Framework.framework/Chromium Framework:
ERROR from command "/b/c/b/mac_ng/src/tools/mac/show_mod_init_func.py /b/c/b/mac_ng/src/out/Release/Chromium Framework.unstripped": 1
# HINT: To get this list, run tools/mac/show_mod_init_func.py
# HINT: diff against the log from the last run to see what changed

 
Status: Started (was: Assigned)
The fix is to just call it with xcrun.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dac8b2225555da9d61adcecea57e867ac06070a

commit 2dac8b2225555da9d61adcecea57e867ac06070a
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Aug 08 15:03:05 2016

Invoke atos via xcrun in tools/mac/show_mod_init_func.py.

BUG= 635529 
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/2225883002 .

Cr-Commit-Position: refs/heads/master@{#410355}

[modify] https://crrev.com/2dac8b2225555da9d61adcecea57e867ac06070a/tools/mac/show_mod_init_func.py

Status: Fixed (was: Started)
https://build.chromium.org/p/chromium/builders/Mac/builds/18359/steps/sizes/logs/stdio

# Static initializers in /b/c/b/mac_ng/src/out/Release/Chromium Framework.framework/Chromium Framework:
# HINT: To get this list, run tools/mac/show_mod_init_func.py
# HINT: diff against the log from the last run to see what changed
/b/c/b/mac_ng/src/out/Release/Chromium Framework.unstripped
0x00000000013489f0 @ _GLOBAL__sub_I_v4_store.cc (in Chromium Framework.unstripped) (v4_store.cc:0)
0x000000000168c3f0 @ _GLOBAL__sub_I_safe_browsing_service.cc (in Chromium Framework.unstripped) (safe_browsing_service.cc:0)
0x00000000016bbc30 @ _GLOBAL__sub_I_local_database_manager.cc (in Chromium Framework.unstripped) (local_database_manager.cc:0)
0x00000000016e6300 @ _GLOBAL__sub_I_services_delegate_impl.cc (in Chromium Framework.unstripped) (services_delegate_impl.cc:0)
0x000000000391ed70 @ _GLOBAL__sub_I_database_manager.cc (in Chromium Framework.unstripped) (database_manager.cc:0)
0x000000000391fd00 @ _GLOBAL__sub_I_util.cc (in Chromium Framework.unstripped) (util.cc:0)
0x0000000003934180 @ _GLOBAL__sub_I_v4_get_hash_protocol_manager.cc (in Chromium Framework.unstripped) (v4_get_hash_protocol_manager.cc:0)
0x0000000003936ef0 @ _GLOBAL__sub_I_v4_local_database_manager.cc (in Chromium Framework.unstripped) (v4_local_database_manager.cc:0)
0x0000000003938990 @ _GLOBAL__sub_I_v4_database.cc (in Chromium Framework.unstripped) (v4_database.cc:0)
0x000000000393a580 @ _GLOBAL__sub_I_v4_update_protocol_manager.cc (in Chromium Framework.unstripped) (v4_update_protocol_manager.cc:0)

Sign in to add a comment