New issue
Advanced search Search tips

Issue 635514 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 635918
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.1%-13.7% regression in startup.warm.blank_page at 410072:410127

Project Member Reported by rmcilroy@chromium.org, Aug 8 2016

Issue description

See the link to graphs below.
 
Cc: kozyatinskiy@chromium.org
Owner: kozyatinskiy@chromium.org

=== Auto-CCing suspected CL author kozyatinskiy@chromium.org ===

Hi kozyatinskiy@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [DevTools] Removed InspectorTest.invokePageFunctionPromise
Author  : kozyatinskiy
Commit description:
  
BUG= 632875 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2207163002
Cr-Commit-Position: refs/heads/master@{#410114}
Commit  : 55da79583bf83778309007c14f53092295cc0a7d
Date    : Fri Aug 05 18:25:14 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@410082  704.08  8.93599  5  good
chromium@410104  671.4   20.1534  5  good
chromium@410111  688.56  16.3042  5  good
chromium@410113  724.04  13.2351  5  good
chromium@410114  746.32  10.0654  5  bad    <--
chromium@410116  738.96  3.08998  5  bad
chromium@410127  740.4   13.3069  8  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 635514

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests startup.cold.blank_page
Test Metric: open_tabs_time/open_tabs_time
Relative Change: 5.23%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2284
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004891691513501840


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5878783106613248

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
kozyatinskiy, is it conceivable that that CL could have affected startup performance on mac?

Note, the graphs are super noisy, so this could be a false positive alert.
Cc: -kozyatinskiy@chromium.org
Owner: qyears...@chromium.org
No, my CL only changes some tests and doesn't affect anything in chrome.

Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Aug 22 2016

Mergedinto: 635918
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [Mac] Only enable the CFBundleBlocker in the browser process. (patchset #1 id:1 of https://codereview.chromium.org/2199313002/ )
Author  : rsesek
Commit description:
  
Reason for revert:
Speculative revert for perf regression.

BUG= https://crbug.com/634917 

Original issue's description:
> [Mac] Only enable the CFBundleBlocker in the browser process.
>
> In child processes, which are sandboxed in most cases, the sandbox will prevent
> access to the filesystem locations where the potentially blocked bundles are
> stored. Furthermore, on macOS 10.11 and higher, the Google Chrome build is
> codesigned in such a way where bundle loading is blocked by SIP.
>
> This reduces some of the "triggered DYLD shared region unnest for map" messages.
>
> BUG= 428858 
> R=mark@chromium.org
>
> Committed: https://crrev.com/65e732d3b4dc595512b731143fd49d372acc1a87
> Cr-Commit-Position: refs/heads/master@{#409244}

TBR=mark@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 428858 

Review-Url: https://codereview.chromium.org/2218163002
Cr-Commit-Position: refs/heads/master@{#410113}
Commit  : 3026ec1f3bd67bb2cac5e42fe6d1a1298efcd049
Date    : Fri Aug 05 18:22:47 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@410082  690.675  8.41627  8  good
chromium@410104  684.0    9.29193  5  good
chromium@410111  681.44   13.562   5  good
chromium@410112  686.08   9.1374   5  good
chromium@410113  718.65   14.7118  4  bad    <--
chromium@410114  726.8    8.1768   5  bad
chromium@410116  723.48   10.2309  5  bad
chromium@410127  713.375  11.5588  8  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 635514

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests startup.cold.blank_page
Test Metric: open_tabs_time/open_tabs_time
Relative Change: 2.70%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2322
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003604696271104736


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5877538388180992

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment