New issue
Advanced search Search tips

Issue 635509 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Run unittests using XCTest on iOS

Project Member Reported by rohitrao@chromium.org, Aug 8 2016

Issue description

It is possible to run gtests using the xctest test runner.  See https://github.com/google/google-toolbox-for-mac/blob/master/UnitTesting/GTMGoogleTestRunner.mm for an example implementation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9315e90cf523b90010145980f953f86c077a51

commit fc9315e90cf523b90010145980f953f86c077a51
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Aug 09 16:26:50 2016

Adds support for running unittests using XCTest on iOS.

Modifies the base TestSuite to check if running under XCTest and return early
without running tests if so.  This allows XCTest to drive running the individual
tests, while still allowing the TestSuite to perform setup tasks.

BUG=635509

Review-Url: https://codereview.chromium.org/2226623003
Cr-Commit-Position: refs/heads/master@{#410698}

[modify] https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51/base/test/test_suite.cc
[modify] https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51/base/test/test_support_ios.h
[modify] https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51/base/test/test_support_ios.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e32d99be07ac02f74efaa502c18a7b3f7a550788

commit e32d99be07ac02f74efaa502c18a7b3f7a550788
Author: olivierrobin <olivierrobin@chromium.org>
Date: Wed Aug 10 12:49:54 2016

Revert of Adds support for running unittests using XCTest on iOS. (patchset #2 id:20001 of https://codereview.chromium.org/2226623003/ )

Reason for revert:
frezes unittests on ios bots.

Original issue's description:
> Adds support for running unittests using XCTest on iOS.
>
> Modifies the base TestSuite to check if running under XCTest and return early
> without running tests if so.  This allows XCTest to drive running the individual
> tests, while still allowing the TestSuite to perform setup tasks.
>
> BUG=635509
>
> Committed: https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51
> Cr-Commit-Position: refs/heads/master@{#410698}

TBR=phajdan.jr@chromium.org,mark@chromium.org,rohitrao@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635509

Review-Url: https://codereview.chromium.org/2231813002
Cr-Commit-Position: refs/heads/master@{#411028}

[modify] https://crrev.com/e32d99be07ac02f74efaa502c18a7b3f7a550788/base/test/test_suite.cc
[modify] https://crrev.com/e32d99be07ac02f74efaa502c18a7b3f7a550788/base/test/test_support_ios.h
[modify] https://crrev.com/e32d99be07ac02f74efaa502c18a7b3f7a550788/base/test/test_support_ios.mm

Comment 3 Deleted

Comment 4 Deleted

I entered the wrong bug numbers in my CLs.

Sorry for that...
Hi Rohit, are you still working on this?
Cc: rohitrao@chromium.org
Owner: ----
Status: Available (was: Started)
I'm not working on this, and I'm not sure how to proceed.  My initial attempt failed because the bots run gtests in an XCTest-like mode.  I need to find a way to tell the bots apart from a human user running in XCTest mode, because in the former case we want gtest to run tests, but in the latter case we need to prevent gtest from running tests directly.
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 21

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: justincohen@chromium.org
Status: Available (was: Untriaged)
rohitrao@ should anyone still be working on this?

Sign in to add a comment