SpellCheckProvider should not attempt to decide typing progress |
||||||||||||||
Issue descriptionVersion: ToT OS: All What steps will reproduce the problem? (1) Open data:text/html, <div contenteditable>zz a</div> (2) Focus the <div> What is the expected output? "zz" should be marked as misspelled by red waves What do you see instead? Nothing is marked. Further investigation shows that SpellCheckProvider::SatisfyRequestFromCache() always cancels the request at line 327: https://cs.chromium.org/chromium/src/chrome/renderer/spellchecker/spellcheck_provider.cc?rcl=1470626560&l=327
,
Aug 8 2016
,
Aug 8 2016
It turns out that crrev.com/2221903002 broke unit test SpellCheckProviderTest.MultiLineText, failing the 2nd and 3rd assertions. It seems that the behavior reported in this issue is intended, as the unit test states "SpellCheckProvider class does not spellcheck text while we are typing a word". However, it also mistakenly determines some other cases as "while typing", including the case in the issue description. I'm wondering whether SpellCheckProvider should judge if the user is typing. It seems that Blink is a better place to do this job.
,
Nov 21 2016
,
Nov 21 2016
,
Nov 21 2016
,
Nov 21 2016
,
Nov 21 2016
,
Dec 7 2016
,
Feb 24 2017
Changing issue summary. SpellCheckProvider has no reliable way to check the typing progress, and hence, should not check it. This job should be done in Blink.
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e commit 0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Feb 24 19:18:23 2017 Stop SpellCheckProvider from deciding typing progress In order not to check spelling in the middle of typing a word, SpellCheckProvider used to decide the typing process, which is a job that it can't reliably accomplish due to lack of information. Now that the Blink-side SpellChecker class is no longer sending spell check requests in the middle of typing a word, there is no need for SpellCheckProvider to perform the check. Hence, this patch removes the related code from SpellCheckProvider, and modifies tests accordingly. BUG= 635504 TEST=SpellCheckProviderTest.MultiLineText Review-Url: https://codereview.chromium.org/2712833004 Cr-Commit-Position: refs/heads/master@{#452899} [modify] https://crrev.com/0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e/components/spellcheck/renderer/spellcheck_provider.cc [modify] https://crrev.com/0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e/components/spellcheck/renderer/spellcheck_provider.h [modify] https://crrev.com/0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e/components/spellcheck/renderer/spellcheck_provider_hunspell_unittest.cc
,
Feb 24 2017
,
Feb 24 2017
,
Feb 24 2017
,
Feb 24 2017
,
Feb 24 2017
,
Feb 24 2017
,
Apr 27 2017
,
Jun 12 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by xiaoche...@chromium.org
, Aug 8 2016