New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635490 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 635489
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 635830



Sign in to add a comment

1.8%-16.7% regression in system_health.memory_desktop at 410128:410198

Project Member Reported by petrcermak@chromium.org, Aug 8 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=635490

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1pG3oQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglpOQtAoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-hdd

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@410127  3145728  0.0      5  good
chromium@410198  3670016  0.0      3  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 635490

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_games_lazors
Relative Change: 16.67%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/721
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004896418348728848


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5878089872048128

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Blockedon: 635830
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 10 2016

Mergedinto: 635489
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert "Raster display item lists via a visual rect RTree."
Author  : wkorman
Commit description:
  
Meta-revert for http://crrev.com/1484163002 due to bugs found in ui/views and
DevTools.

Original change description:

    Raster display item lists via a visual rect RTree.

    Rather than caching and playing back an entire SkPicture
    when rastering a display item list for a particular
    playback rect, instead retain display items and query
    them via an RTree of their visual rects to find and
    raster only what's needed.

    Display item lists no longer support the notion of a
    bounding "layer rect" with mutable origin.

    DisplayItemListSettings proto is obsolete after this
    change as it's comprised solely of one field to allow
    switching whether to use the aforementioned now-deleted
    cached SkPicture code path. It will be deleted in a
    subsequent patch.

Revert "Raster display item lists via a visual rect RTree."

This reverts commit ccb9e13712b1632b889960d1d85d556c0139fd51.

Revert "Don't clear visual rects when finalizing display item lists for now."

This reverts commit 1adf72a0a0a3e04151cc740d15ab19655b1e7e5e.

Revert "Delete obsolete DisplayItemList::ProcessAppendedItem method definition."

This reverts commit f652746f56c59523b0440cf18b769f8ba779d15d.

BUG= 529938 , 633750 , 633869 , 634239 , 634823 , 634959 
TBR=chrishtr@chromium.org,vmpstr@chromium.org,lushnikov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2217263003
Cr-Commit-Position: refs/heads/master@{#410190}
Commit  : 490867260447e9360b52d5c03417b000490332e0
Date    : Fri Aug 05 22:27:03 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@410127  3145728  0.0      5  good
chromium@410163  3145728  0.0      5  good
chromium@410181  3145728  0.0      5  good
chromium@410186  3145728  0.0      5  good
chromium@410188  3145728  0.0      5  good
chromium@410189  3145728  0.0      5  good
chromium@410190  3670016  0.0      5  bad    <--
chromium@410198  3670016  0.0      5  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 635490

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_games_lazors
Relative Change: 16.67%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/724
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004809872334062960


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5299505298145280

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff

Sign in to add a comment