New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635489 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 529938



Sign in to add a comment

1.4%-2.2% regression in system_health.memory_desktop at 410188:410234

Project Member Reported by petrcermak@chromium.org, Aug 8 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=635489

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglpXApgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglvPRpgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1p7IrQkM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-gpu-intel
chromium-rel-win8-dual
Cc: wkorman@chromium.org
Owner: wkorman@chromium.org

=== Auto-CCing suspected CL author wkorman@chromium.org ===

Hi wkorman@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert "Raster display item lists via a visual rect RTree."
Author  : wkorman
Commit description:
  
Meta-revert for http://crrev.com/1484163002 due to bugs found in ui/views and
DevTools.

Original change description:

    Raster display item lists via a visual rect RTree.

    Rather than caching and playing back an entire SkPicture
    when rastering a display item list for a particular
    playback rect, instead retain display items and query
    them via an RTree of their visual rects to find and
    raster only what's needed.

    Display item lists no longer support the notion of a
    bounding "layer rect" with mutable origin.

    DisplayItemListSettings proto is obsolete after this
    change as it's comprised solely of one field to allow
    switching whether to use the aforementioned now-deleted
    cached SkPicture code path. It will be deleted in a
    subsequent patch.

Revert "Raster display item lists via a visual rect RTree."

This reverts commit ccb9e13712b1632b889960d1d85d556c0139fd51.

Revert "Don't clear visual rects when finalizing display item lists for now."

This reverts commit 1adf72a0a0a3e04151cc740d15ab19655b1e7e5e.

Revert "Delete obsolete DisplayItemList::ProcessAppendedItem method definition."

This reverts commit f652746f56c59523b0440cf18b769f8ba779d15d.

BUG= 529938 , 633750 , 633869 , 634239 , 634823 , 634959 
TBR=chrishtr@chromium.org,vmpstr@chromium.org,lushnikov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2217263003
Cr-Commit-Position: refs/heads/master@{#410190}
Commit  : 490867260447e9360b52d5c03417b000490332e0
Date    : Fri Aug 05 22:27:03 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N  Good?
chromium@410187  15810092  101540   5  good
chromium@410189  15696619  94349.5  5  good
chromium@410190  15995887  100831   5  bad    <--
chromium@410192  15992972  73712.2  5  bad
chromium@410197  16007335  67622.6  5  bad
chromium@410206  16074621  55098.9  5  bad
chromium@410232  15983938  76283.7  5  bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 635489

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:winheap:effective_size_avg/load_social_pinterest
Relative Change: 1.10%
Score: 95.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2106
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004896466066117840


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5871339122982912

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Blockedon: 529938
We will be relanding the reverted change shortly. Blocking this on that work.
Labels: SystemHealth-Sheriff
Status: Fixed (was: Assigned)
We re-landed the change on Aug 12:

https://chromium.lc/chromium/commit/?id=971a9c9725e293bd89b7cb1475acdc502065e6b3

The graph is 500'ing for me but we should have seen memory usage recovery.

Sign in to add a comment