New issue
Advanced search Search tips

Issue 635485 link

Starred by 1 user
Status: Duplicate
Merged: issue 635483
Owner:
u...@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.7%-33.3% regression in system_health.memory_desktop at 410044:410060

Project Member Reported by petrcermak@chromium.org, Aug 8 2016 
See the link to graphs below.

Comment 1 by petrcermak@chromium.org, Aug 8 2016 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=635485

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1pjjoAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg5tuepgkM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 8 2016 


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@410043  3757397  539942   12  good
chromium@410060  3801088  542690   8   bad

Bisect job ran on: winx64ati_perf_bisect
Bug ID: 635485

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_search-memory:chrome:all_processes:reported_by_chrome:v8:heap:code_space:effective_size_avg/load_search_yahoo
Relative Change: 0.00%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64ati_perf_bisect/builds/1497
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004896679172038512


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5777336784388096

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by petrcermak@chromium.org, Aug 9 2016

Owner: u...@chromium.org
ulan: Are you interested in this regression (in v8:heap:code_space), or should we mark it as WontFix? (I requested removing V8-specific values from SH perf sheriffing in  issue 635901 ).

Comment 8 by petrcermak@chromium.org, Aug 30 2016

Labels: SystemHealth-Sheriff
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Aug 30 2016

Mergedinto: 635483
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Clear all preloads when document is detached
Author  : yoav
Commit description:
  
Currently link rel preload based preloads are never evicted from MemoryCache. This fixes that
by evicting all preloads when the document is detached.

This also fixes issues found when Link preloads were not reused after DCL due to bugs inside clearPreloads().

BUG=627026

Review-Url: https://codereview.chromium.org/2174563003
Cr-Commit-Position: refs/heads/master@{#410008}
Commit  : 57696ed320e6ed0263b7c447ef17bb6bef5236ca
Date    : Fri Aug 05 07:06:05 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@409917  2822095  610193   5  good
chromium@409984  2807054  600707   5  good
chromium@410001  2992552  517980   5  good
chromium@410006  3228625  40234.8  5  good
chromium@410007  2759330  627558   5  good
chromium@410008  5490468  540723   5  bad    <--
chromium@410010  5058323  692871   5  bad
chromium@410018  5756884  4777.49  5  bad
chromium@410051  5473197  594199   5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 635485

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: browse_social-memory:chrome:all_processes:reported_by_chrome:web_cache:effective_size_avg/browse_social_twitter
Relative Change: 93.94%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1622
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002917528916730640


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5215359456509952

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Aug 31 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Clear all preloads when document is detached
Author  : yoav
Commit description:
  
Currently link rel preload based preloads are never evicted from MemoryCache. This fixes that
by evicting all preloads when the document is detached.

This also fixes issues found when Link preloads were not reused after DCL due to bugs inside clearPreloads().

BUG=627026

Review-Url: https://codereview.chromium.org/2174563003
Cr-Commit-Position: refs/heads/master@{#410008}
Commit  : 57696ed320e6ed0263b7c447ef17bb6bef5236ca
Date    : Fri Aug 05 07:06:05 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@409974  4967312  0.0      5  good
chromium@409995  4967312  0.0      5  good
chromium@410007  4967312  0.0      5  good
chromium@410008  5261224  0.0      5  bad    <--
chromium@410009  5261224  0.0      5  bad
chromium@410010  5261224  0.0      5  bad
chromium@410013  5261224  0.0      5  bad
chromium@410018  5261224  0.0      5  bad
chromium@410061  5261224  0.0      5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 635485

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:web_cache:effective_size_avg/load_social_twitter
Relative Change: 5.92%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1153
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002917548261035936


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4955571655016448

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Aug 31 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Clear all preloads when document is detached
Author  : yoav
Commit description:
  
Currently link rel preload based preloads are never evicted from MemoryCache. This fixes that
by evicting all preloads when the document is detached.

This also fixes issues found when Link preloads were not reused after DCL due to bugs inside clearPreloads().

BUG=627026

Review-Url: https://codereview.chromium.org/2174563003
Cr-Commit-Position: refs/heads/master@{#410008}
Commit  : 57696ed320e6ed0263b7c447ef17bb6bef5236ca
Date    : Fri Aug 05 07:06:05 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@409974  2923666  566267   5  good
chromium@409995  3155868  0.0      5  good
chromium@410007  3190628  47715.0  5  good
chromium@410008  5687136  40982.7  5  bad    <--
chromium@410009  5668808  0.0      5  bad
chromium@410010  5668808  0.0      5  bad
chromium@410013  5668808  0.0      5  bad
chromium@410018  5685240  36743.1  5  bad
chromium@410061  5687136  40982.7  5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 635485

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: browse_social-memory:chrome:all_processes:reported_by_chrome:web_cache:effective_size_avg/browse_social_twitter
Relative Change: 94.52%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1154
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002917510576316784


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5872193173454848

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
►

Sign in to add a comment