Issue metadata
Sign in to add a comment
|
Regression : Unnecessary tool tip is seen even when there is no zoom icon in omnibox.
Reported by
mni...@etouch.net,
Aug 8 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 54.0.2823.0 c6b7050c321314686730fb679a7122341f16c7c2-refs/heads/master@{#410278} (64-bit) OS : Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? 1. Launch chrome , open NTP and press 'Cmd ++' keys from keyboard in order to zoom in the page. 2. Now press 'Cmd + 0' key from keyboard to reset the page and immediately hover the mouse in omnibox near Bookmark icon,observe Actual: Unnecessary tool tip is seen when there is no icon for ZOOM_NORMAL state in zoom decoration Expected: Unnecessary tool tip should not be seen when there is no icon for ZOOM_NORMAL state in zoom decoration This is a regression issue broken in 'M-51' and below is the manual regression and Narrow bisect info : Good Build: 51.0.2699.0 Bad Build: 51.0.2701.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/a0c60b763daf634d614a3a641306d4c8ea84e27c..0f6bff6e28623962039cd937efee659e66dae76f?pretty=fuller&n=50 Suspecting: r385192 from Narrow bisect @shrike : Kindly help to re-assign, if your changes are not cause for this issue. Note : Issue is not seen on Linux and Windows OS.
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c12fa88b187817e55ad6ccfc0416aec46cfd8314 commit c12fa88b187817e55ad6ccfc0416aec46cfd8314 Author: shrike <shrike@chromium.org> Date: Fri Oct 14 18:21:59 2016 [Mac] Don't show tooltip when zoom decoration is hidden. In Material Design the zoom decoration is hidden when the zoom factor is 100%. When the zoom decoration's tooltip should only be visible when the decoration is visible. R=avi@chromium.org, dbeam@chromium.org BUG= 635480 Review-Url: https://codereview.chromium.org/2415453004 Cr-Commit-Position: refs/heads/master@{#425389} [modify] https://crrev.com/c12fa88b187817e55ad6ccfc0416aec46cfd8314/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm [modify] https://crrev.com/c12fa88b187817e55ad6ccfc0416aec46cfd8314/chrome/browser/ui/cocoa/location_bar/zoom_decoration_unittest.mm [modify] https://crrev.com/c12fa88b187817e55ad6ccfc0416aec46cfd8314/components/zoom/zoom_controller.h
,
Oct 14 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Oct 12 2016