New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635476 link

Starred by 3 users
Status: Fixed
Owner:
enne@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ siev...@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Blank window is seen after clicking on "Attach a photo" icon in hangouts app.

Reported by adha...@etouch.net, Aug 8 2016 
Chrome Version: 54.0.2823.1 (Official Build) 787b4d3322f8e433876ccb912291f3239c786a09-refs/branch-heads/2823@{#1}(32/64-bit)
OS: Mac (10.10.5, 10.11.5), Windows (7,8,10)

TEST URL:https://chrome.google.com/webstore/detail/google-hangouts/knipolnnllmklapflnccelgolnpehhpl?utm_source=chrome-ntp-icon

Steps:
(1)Launch chrome,navigate to the above url and click on add to chrome.
(2)Sign In with valid credentials,Open a chat window and click on "Attach a photo" icon.
(3)Observe.

Actual:Blank window is seen after clicking on "Attach a photo" icon.

Expected:Attachment window should be seen properly.

This is a Regression issue broken in M-54,will soon update other info.

Comment 1 by adha...@etouch.net, Aug 8 2016

Cc: vabr@chromium.org
Labels: hasbisect OS-Linux
Owner: jbroman@chromium.org
Status: Assigned (was: Unconfirmed)
Good build:54.0.2809.0
Bad build:54.0.2810.0

Change log info:
https://chromium.googlesource.com/chromium/src/+log/54.0.2809.0..54.0.2810.0?pretty=fuller&n=10000

Suspecting:r408043?

Kindly help to re-assign if your change is not the cause for this issue.

Note:
(1)Unable to sign in to hangout app on chromium build, hence provide suspect from change log.
(2)Above issue is also reproducible on Linux OS.
Actual result.mp4
627 KB View Download
Expected result.mp4
364 KB View Download

Comment 2 by ranjitkan@chromium.org, Aug 8 2016

Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.

Comment 3 by jbroman@chromium.org, Aug 8 2016

Components: Internals>Compositing
Owner: enne@chromium.org
I was able to bisect on local Chromium builds, by building with API keys and signing in using the title bar before the Hangouts app tries to login.

The bisect comes back to enabling begin frame scheduling:
https://chromium.googlesource.com/chromium/src/+/d020d554c9ffc0476d43f5364a47c522b64e3d9a

Comment 4 by vabr@chromium.org, Aug 9 2016

Cc: -vabr@chromium.org
(Not sure why I was Cc-ed here. Please add me back if you there are any questions for me.)

Comment 5 by brajkumar@chromium.org, Aug 17 2016 

enne@ - Any update on this bug? Will you mind looking in to this issue.

Comment 6 by enne@chromium.org, Aug 17 2016

Cc: siev...@chromium.org
Waiting on sievers to review https://codereview.chromium.org/2242613003
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71de85ec0f6f6259824758b10db751b65b005bd2

commit 71de85ec0f6f6259824758b10db751b65b005bd2
Author: enne <enne@chromium.org>
Date: Mon Aug 22 21:11:59 2016

Hoist SetNeedsBeginFrame messages up to the RWHostImpl

Previously, each RenderWidgetHostView class handled all of the
SetNeedsBeginFrameMessages sent from the renderer.  However, in the case
that the render widget is initialized before the view is set, then the
SetNeedsBeginFrame message is dropped and then that renderer is never
ticked with begin frame messages.

To fix this, have the RenderWidgetHostImpl handle SetNeedsBeginFrame
messages, remember the value, and forward it to the view whenever the
view is set so the message is not lost.

R=sievers@chromium.org
BUG= 635476 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2242613003
Cr-Commit-Position: refs/heads/master@{#413533}

[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_mus.cc
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/browser/renderer_host/render_widget_host_view_mus.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/public/browser/render_widget_host_view.h
[modify] https://crrev.com/71de85ec0f6f6259824758b10db751b65b005bd2/content/test/test_render_view_host.h

Comment 8 by enne@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment