Issue metadata
Sign in to add a comment
|
1.3% regression in webrtc.peerconnection at 410131:410202 |
||||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 8 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004901738753350288
,
Aug 8 2016
===== BISECT JOB RESULTS ===== Status: failed ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@410130 42380.0 91.6079 5 good chromium@410166 42452.8 43.3959 5 good chromium@410184 42352.8 84.019 5 good chromium@410189 42460.0 75.7364 5 good chromium@410190 43148.8 69.708 5 bad chromium@410191 43141.6 133.435 5 bad chromium@410193 43127.2 96.8876 5 bad chromium@410202 43179.2 97.0526 5 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 635468 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests webrtc.peerconnection Test Metric: vm_private_dirty_final_renderer/vm_private_dirty_final_renderer Relative Change: 1.89% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/898 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004901738753350288 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5884053299920896 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 8 2016
wkorman: Looks like 'Raster display item lists via a visual rect RTree' made some performance improvements to this test, and its revert regressed them. Not sure if there's anything we can do here?
,
Aug 8 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004881243364810640
,
Aug 8 2016
===== BISECT JOB RESULTS ===== Status: failed ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@410130 42380.0 91.6079 5 good chromium@410166 42452.8 43.3959 5 good chromium@410184 42352.8 84.019 5 good chromium@410189 42460.0 75.7364 5 good chromium@410190 43148.8 69.708 5 bad chromium@410191 43141.6 133.435 5 bad chromium@410193 43127.2 96.8876 5 bad chromium@410202 43179.2 97.0526 5 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 635468 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests webrtc.peerconnection Test Metric: vm_private_dirty_final_renderer/vm_private_dirty_final_renderer Relative Change: 1.89% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/898 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004901738753350288 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5884053299920896 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 9 2016
We will be re-landing the cc r-tree patch soon. It is a priority to get it into M54. See bugs blocking http://crbug.com/529938 for the work to be resolved in some manner before re-land. I will mark this bug as blocked on http://crbug.com/529938 . That said it's surprising that webrtc would benefit from a raster/paint change, though it is a notable shift in raster approach. Maybe due to altering the profile of cpu utilization?
,
Aug 9 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004789828150680768
,
Aug 9 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert "Raster display item lists via a visual rect RTree." Author : wkorman Commit description: Meta-revert for http://crrev.com/1484163002 due to bugs found in ui/views and DevTools. Original change description: Raster display item lists via a visual rect RTree. Rather than caching and playing back an entire SkPicture when rastering a display item list for a particular playback rect, instead retain display items and query them via an RTree of their visual rects to find and raster only what's needed. Display item lists no longer support the notion of a bounding "layer rect" with mutable origin. DisplayItemListSettings proto is obsolete after this change as it's comprised solely of one field to allow switching whether to use the aforementioned now-deleted cached SkPicture code path. It will be deleted in a subsequent patch. Revert "Raster display item lists via a visual rect RTree." This reverts commit ccb9e13712b1632b889960d1d85d556c0139fd51. Revert "Don't clear visual rects when finalizing display item lists for now." This reverts commit 1adf72a0a0a3e04151cc740d15ab19655b1e7e5e. Revert "Delete obsolete DisplayItemList::ProcessAppendedItem method definition." This reverts commit f652746f56c59523b0440cf18b769f8ba779d15d. BUG= 529938 , 633750 , 633869 , 634239 , 634823 , 634959 TBR=chrishtr@chromium.org,vmpstr@chromium.org,lushnikov@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2217263003 Cr-Commit-Position: refs/heads/master@{#410190} Commit : 490867260447e9360b52d5c03417b000490332e0 Date : Fri Aug 05 22:27:03 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@410130 42448.0 74.027 5 good chromium@410166 42413.6 47.1254 5 good chromium@410184 42400.0 80.9444 5 good chromium@410189 42400.8 75.0147 5 good chromium@410190 43158.4 60.8342 5 bad <-- chromium@410191 43164.8 144.51 5 bad chromium@410193 43086.4 91.0648 5 bad chromium@410202 43196.8 156.548 5 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 635468 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests webrtc.peerconnection Test Metric: vm_private_dirty_final_renderer/vm_private_dirty_final_renderer Relative Change: 1.76% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/903 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004901738753350288 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5884053299920896 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rmcilroy@chromium.org
, Aug 8 2016