New issue
Advanced search Search tips

Issue 635467 link

Starred by 0 users
Status: Duplicate
Merged: issue 635464
Owner:
erikc...@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.7%-8.8% regression in power.top_25 at 410128:410177

Project Member Reported by rmcilroy@chromium.org, Aug 8 2016 
See the link to graphs below.
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 8 2016 


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@410147  1262.2  18.6467  5  good
chromium@410161  1263.8  12.5579  5  good
chromium@410162  1263.0  13.3229  5  good
chromium@410163  1380.0  47.8957  5  bad
chromium@410165  1364.2  9.52365  5  bad
chromium@410168  1355.0  32.5807  5  bad
chromium@410175  1360.8  44.6509  5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 635467

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.tough_energy_cases
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 7.81%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2279
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004901747555558736


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860230726942720

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by sullivan@chromium.org, Aug 8 2016

Owner: erikc...@chromium.org
Status: Fixed (was: Assigned)
erikchen: Looks like this CL was already reverted for other reasons, but bisect shows it causing this regression too: https://codereview.chromium.org/2215513002
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 8 2016 


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@410147  1262.2  18.6467  5  good
chromium@410161  1263.8  12.5579  5  good
chromium@410162  1263.0  13.3229  5  good
chromium@410163  1380.0  47.8957  5  bad
chromium@410165  1364.2  9.52365  5  bad
chromium@410168  1355.0  32.5807  5  bad
chromium@410175  1360.8  44.6509  5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 635467

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.tough_energy_cases
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 7.81%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2279
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004901747555558736


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860230726942720

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Mergedinto: 635464
Status: Duplicate (was: Fixed)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland #1: "base: Implement GetCurrentThreadPriority."
Author  : erikchen
Commit description:
  
The Chrome thread priority is saved in the thread dictionary during
SetCurrentThreadPriority(). This seemed a better approach than using
thread_policy_get(), since there are 4 Chrome priorities which won't cleanly map
to thread flavors.

BUG=601270

Review-Url: https://codereview.chromium.org/2215513002
Cr-Commit-Position: refs/heads/master@{#410163}
Commit  : 23d10a36f2e815edd610098a65e5890f279d2183
Date    : Fri Aug 05 21:19:08 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@410147  1244.2  29.1067  5  good
chromium@410161  1258.2  8.52643  5  good
chromium@410162  1242.0  20.3838  5  good
chromium@410163  1369.4  19.308   5  bad    <--
chromium@410165  1357.8  12.7554  5  bad
chromium@410168  1360.0  37.6829  4  bad
chromium@410175  1373.6  26.1304  5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 635467

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.tough_energy_cases
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 10.40%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2288
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004901747555558736


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860230726942720

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
►

Sign in to add a comment