Issue 635466 link

Starred by 1 user

Issue metadata

Status:	Duplicate
Merged:	issue 635489
Owner:	----
Closed:	Aug 2016
Cc:	dpa...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug-Regression
M-54 Performance-Sheriff

3.8%-271.6% regression in blink_perf.paint at 410130:410212

Project Member Reported by rmcilroy@chromium.org, Aug 8 2016

Issue description

See the link to graphs below.

Comment 1 by rmcilroy@chromium.org, Aug 8 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=635466

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgluOHpQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgloe8tQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglvv3uQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglp_SpQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglvXLtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1vTkpAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgluqHtQoM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
chromium-rel-mac-retina
chromium-rel-win7-x64-dual
linux-release

Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Aug 8 2016

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004901935149471968

Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 8 2016

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004890395435352192

Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Aug 8 2016

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004885952931941856

Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 8 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean       Std Dev      N   Good?
chromium@410176  0.0360648  0.00016863   18  good
chromium@410184  0.0361389  0.000142915  18  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 635466

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests rasterize_and_record_micro.top_25_smooth
Test Metric: record_time/record_time
Relative Change: 0.16%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6626
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004901935149471968


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5875049035202560

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Cc: dpa...@chromium.org
Owner: dpa...@chromium.org


=== Auto-CCing suspected CL author dpapad@chromium.org ===

Hi dpapad@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : MD Settings: About page, force line breaks in "Command line" string.
Author  : dpapad
Commit description:
  
BUG=635020
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2219803003
Cr-Commit-Position: refs/heads/master@{#410177}
Commit  : 070f89c9808629a65f02a0f3c818a31c873b3e9e
Date    : Fri Aug 05 21:54:40 2016


===== TESTED REVISIONS =====
Revision         Mean       Std Dev      N  Good?
chromium@410176  0.050669   0.000908933  5  good
chromium@410177  0.0576621  0.000625175  5  bad    <--
chromium@410178  0.0580207  0.000399613  5  bad
chromium@410180  0.0578345  0.000431655  5  bad
chromium@410184  0.0579862  0.000349622  5  bad

Bisect job ran on: win_perf_bisect
Bug ID: 635466

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests rasterize_and_record_micro.key_silk_cases
Test Metric: record_time/record_time
Relative Change: 14.44%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6817
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004890395435352192


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5834441730031616

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Aug 9 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : MD Settings: About page, force line breaks in "Command line" string.
Author  : dpapad
Commit description:
  
BUG=635020
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2219803003
Cr-Commit-Position: refs/heads/master@{#410177}
Commit  : 070f89c9808629a65f02a0f3c818a31c873b3e9e
Date    : Fri Aug 05 21:54:40 2016


===== TESTED REVISIONS =====
Revision         Mean       Std Dev      N  Good?
chromium@410176  0.0514621  0.000669356  5  good
chromium@410177  0.0578966  0.000648331  5  bad    <--
chromium@410178  0.0585862  0.000524659  5  bad
chromium@410180  0.0581379  0.000343964  5  bad
chromium@410184  0.0572069  0.000610549  5  bad

Bisect job ran on: win_perf_bisect
Bug ID: 635466

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests rasterize_and_record_micro.key_silk_cases
Test Metric: record_time/record_time
Relative Change: 11.16%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6818
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004885952931941856


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5907490533801984

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 8 by sullivan@chromium.org, Aug 9 2016

Owner: ----

Wow, that is *very* strange that the bisect keeps pinpointing dpapad's CL, it doesn't seem like it could be related. Trying a bisect on another platform.

Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004797850502964880

Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Mergedinto: 635489
Status: Duplicate (was: Assigned)


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert "Raster display item lists via a visual rect RTree."
Author  : wkorman
Commit description:
  
Meta-revert for http://crrev.com/1484163002 due to bugs found in ui/views and
DevTools.

Original change description:

    Raster display item lists via a visual rect RTree.

    Rather than caching and playing back an entire SkPicture
    when rastering a display item list for a particular
    playback rect, instead retain display items and query
    them via an RTree of their visual rects to find and
    raster only what's needed.

    Display item lists no longer support the notion of a
    bounding "layer rect" with mutable origin.

    DisplayItemListSettings proto is obsolete after this
    change as it's comprised solely of one field to allow
    switching whether to use the aforementioned now-deleted
    cached SkPicture code path. It will be deleted in a
    subsequent patch.

Revert "Raster display item lists via a visual rect RTree."

This reverts commit ccb9e13712b1632b889960d1d85d556c0139fd51.

Revert "Don't clear visual rects when finalizing display item lists for now."

This reverts commit 1adf72a0a0a3e04151cc740d15ab19655b1e7e5e.

Revert "Delete obsolete DisplayItemList::ProcessAppendedItem method definition."

This reverts commit f652746f56c59523b0440cf18b769f8ba779d15d.

BUG= 529938 , 633750 , 633869 , 634239 , 634823 , 634959 
TBR=chrishtr@chromium.org,vmpstr@chromium.org,lushnikov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2217263003
Cr-Commit-Position: refs/heads/master@{#410190}
Commit  : 490867260447e9360b52d5c03417b000490332e0
Date    : Fri Aug 05 22:27:03 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev      N  Good?
chromium@410129  0.044   0.0          5  good
chromium@410167  0.0438  0.000447214  5  good
chromium@410186  0.0442  0.000447214  5  good
chromium@410189  0.044   0.000707107  5  good
chromium@410190  0.2706  0.00134164   5  bad    <--
chromium@410191  0.2686  0.00114018   5  bad
chromium@410196  0.2706  0.004219     5  bad
chromium@410205  0.2692  0.000447214  5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 635466

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests rasterize_and_record_micro.top_25_smooth
Test Metric: record_time/http___booking.com
Relative Change: 511.82%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6629
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004797850502964880


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6452562484527104

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

►

Issue 635466 link

Issue metadata

3.8%-271.6% regression in blink_perf.paint at 410130:410212

Issue description

Comment 1 by rmcilroy@chromium.org, Aug 8 2016

Comment 1 Deleted

Comment 2 by 42576172...@developer.gserviceaccount.com, Aug 8 2016

Comment 2 Deleted

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 8 2016

Comment 3 Deleted

Comment 4 by 42576172...@developer.gserviceaccount.com, Aug 8 2016

Comment 4 Deleted

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 8 2016

Comment 5 Deleted

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Comment 6 Deleted

Comment 7 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Comment 7 Deleted

Comment 8 by sullivan@chromium.org, Aug 9 2016

Comment 8 Deleted

Comment 9 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Comment 9 Deleted

Comment 10 by 42576172...@developer.gserviceaccount.com, Aug 9 2016

Comment 10 Deleted

Sign in to add a comment