New issue
Advanced search Search tips

Issue 635452 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 179639
issue 517298
issue 635504



Sign in to add a comment

Misspelled words are not marked after consecutive InsertText commands

Project Member Reported by xiaoche...@chromium.org, Aug 8 2016

Issue description

Version: ToT (54.0.2823.0)
OS: All

What steps will reproduce the problem?
(1) Create a content editable <div>
(2) Insert "zz apple" into the <div> by using 8 consecutive InsertText commands, each of which inserts a single character
The attached test.html does the above steps.

What is the expected output?

"zz" should be marked as misspelling

What do you see instead?

No misspelling marker appears

Please use labels and text to provide additional information.

 
test.html
511 bytes View Download
Blockedon: 635504
Components: UI>Browser>Spellcheck
Blockedon: 179639
Cc: rouslan@chromium.org
Summary: Misspelled words are not marked after consecutive InsertText commands (was: Misspelled words are not marked after Consecutive InsertText commands )
I'm not going forward on this issue. 

I tried to fix it with https://codereview.chromium.org/2221783004, but it fails WebFrameTest.SlowSpellcheckMarkerPosition. The unit test was introduced in rouslan@'s fix to  issue 179639 . However, the issue still seems to be there :( The following page partially marks "hewellco", which repros in stable and ToT

<!doctype html>
<div id="div" contenteditable></div>
<script>
var div = document.getElementById('div');
div.focus();
document.execCommand('InsertText', false, 'wellcome ');
window.getSelection().collapse(div, 0);
document.execCommand('InsertText', false, 'he');
</script>

Besides, r350944 removed one line "webInputElement.setSelectionRange(0, 0);" from the unit test. It seems to be changing the logic of the test.
I've seen partial markings myself as well. Not sure how to fix and have not investigated.

Comment 5 by yosin@chromium.org, Oct 5 2016

Components: -UI>Browser>Spellcheck Blink>Editing>Spellcheck
Blockedon: 517298
This issue is due to the current way that spell checker gets triggered, and will be fixed by idle time spell checker.
Status: WontFix (was: Assigned)
Still reproduces with idle time spell checker, as the second InsertText command prevents spellchecker from being invoked.

I don't see an easy way of fixing this without regressing performance. Anyway, this issue seems rather low-priority and artificial, so I'm closing it.

Sign in to add a comment