New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635437 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Focus doesn’t stay on ‘End Process’ button in Chrome Task Manager.

Reported by yfulgaon...@etouch.net, Aug 8 2016

Issue description

Chrome Version : 54.0.2823.0 (Official Build) c6b7050c321314686730fb679a7122341f16c7c2-refs/heads/master@{#410278} (64-bit)
OS: Mac (10.10.5, 10.11.5)

What steps will reproduce the problem?
1. Launch chrome and open Task Manager.
2. Click on any process and press Tab key to move focus on ‘End Process’ button.
3. Observe the focus.

Actual : Focus doesn’t stay on ‘End Process’ button in Chrome Task Manager.

Expected : After step 2, focus should stay on ‘End Process’ button in Chrome Task Manager.

This is a regression issue broken in M-54, below is the Manual Regression and Narrow Bisect info:

Manual Regression :
Good build: 54.0.2816.0
Bad build: 54.0.2817.0

Narrow Bisect : 
https://chromium.googlesource.com/chromium/src/+log/b16b05a3e4f0ef231f2b6a8df10d6ecff4284518..eca522bb64cb9a44646a8d2749ec00b768d3490b?pretty=fuller&n=10000

Suspecting: r409340 from narrow bisect

Note : This is Mac specific issue and not seen on Windows and Linux OS.
 
Actual.mov
5.1 MB Download
Expected.mov
4.1 MB Download
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d20d5e356bf0ebef2967688a1bad2fd98a6383

commit 28d20d5e356bf0ebef2967688a1bad2fd98a6383
Author: avi <avi@chromium.org>
Date: Mon Aug 08 20:35:48 2016

Mac Task Manager: Don't deselect rows before reloading data.

This was needed during development, but now I can't reproduce the situation for which it was needed.

BUG= 528486 , 635437 
TEST=as in bug

Review-Url: https://codereview.chromium.org/2225993002
Cr-Commit-Position: refs/heads/master@{#410443}

[modify] https://crrev.com/28d20d5e356bf0ebef2967688a1bad2fd98a6383/chrome/browser/ui/cocoa/task_manager_mac.mm

Comment 3 by a...@chromium.org, Aug 8 2016

Status: Fixed (was: Assigned)
Labels: TE-Verified-M54 TE-Verified-54.0.2824.0
Rechecked this on chrome version 54.0.2824.0 on MAC 10.11.6. fix is working as intended . Focus stays on the End Process button. Adding TE-verified labels.

Sign in to add a comment