Integer-overflow in gfx::Rect::right |
|||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=4512273148411904 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: gfx::Rect::right gfx::Rect::Intersect cc::PictureLayerImpl::UpdateViewportRectForTilePriorityInContentSpace Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027 Minimized Testcase (1.71 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94H75nQhDnVqm9W3CbGNzdVMRf_d0CBXyNvrI4W_Ddd4EKtq6Hkk7L1t5Ehlwg25KGTFGPvBl1-iR0H5_3Gnv4kZjijaUHRjr10MWW3IgoSTyDpzgNoMHVkf5jt-Jye0DNuNzSg3VhrQcm5mWkk52_X3J4J0w?testcase_id=4512273148411904 Issue manually filed by: ajha See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Aug 8 2016
Integer overflow is a misuse of gfx::Rect. My change was to the internals of gfx::Rect. The first stack frame of the use is cc::PictureLayerImpl::UpdateViewportRectForTilePriorityInContentSpace. Assigning to an owner of that.
,
Aug 8 2016
This maybe a duplicate of issue 635511 or maybe a similar issue. Assigning to vmpstr to investigate as well.
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc7eed4f2a4fbb35d1d243ca07fac20dcb20b07f commit fc7eed4f2a4fbb35d1d243ca07fac20dcb20b07f Author: vmpstr <vmpstr@chromium.org> Date: Thu Aug 11 19:16:48 2016 cc: Change visible rect in content space calculation to not overflow. This patch changes the intersect call to use safe intersect math since the rect intersect version might overflow (although it is likely faster) R=enne, danakj BUG= 635432 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2234183002 Cr-Commit-Position: refs/heads/master@{#411396} [modify] https://crrev.com/fc7eed4f2a4fbb35d1d243ca07fac20dcb20b07f/cc/layers/picture_layer_impl.cc
,
Aug 11 2016
This one should be fixed.
,
Aug 12 2016
vmpstr@: Once the fix is baked in canary, Shall we get this merged to M-53 as well. CF shows this impacting M-52 and M-53. Thank you!
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ajha@chromium.org
, Aug 8 2016Components: Internals
Labels: Te-Logged M-53
Owner: a...@chromium.org
Status: Assigned (was: Untriaged)