New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635428 link

Starred by 1 user
Status: Fixed
Owner:
█ vabr@chromium.org
hobby only
Closed: Aug 2016
Cc:
vasi...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

PasswordManager_SyncCredentialUsed logs wrong counts

Project Member Reported by vabr@chromium.org, Aug 8 2016 
PasswordManager_SyncCredentialUsed should log how many times the user "submits an autofilled credential which matches their sync account".

Instead, it counts how many times the user decides to update a saved credential.

vasilii@ tells me that the second metric is also useful, so the plan is to:

* Keep the existing metric.
* Add a new one matching the current description of PasswordManager_SyncCredentialUsed

Not sure how renaming of user actions is supported. Ideally, PasswordManager_SyncCredentialUsed should become the name of the latter action, but let's check this with the reviewed of the coming CL.

Comment 1 by vabr@chromium.org, Aug 8 2016

Status: Assigned (was: Started)
Correction to #0:

Currently, PasswordManager_SyncCredentialUsed records how many times either:
* Chrome filled a password and the user used it to successfully log in without changing it, or
* Chrome filled, user changed and successfully used a password, then Chrome asked whether to update it, and user agreed.

Vasilii, please confirm whether the above is the metric you found useful, or if not, which one you need. I will then upload a corresponding CL.

Thanks!
Vaclav

Comment 2 by vasi...@chromium.org, Aug 8 2016 

I found it useful in the CM API. Ideally I'd split those two events and track both.

Comment 3 by vabr@chromium.org, Aug 8 2016 

Just to avoid confusion: the above metric excludes the cases when Chrome fills, the user changes, and then declines to update the stored credential. Is that what you want?
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a69d6d6755a3f7c645ea682d777e55d7d4340b3

commit 3a69d6d6755a3f7c645ea682d777e55d7d4340b3
Author: vabr <vabr@chromium.org>
Date: Wed Aug 10 08:06:16 2016

Fix sync-credential-related metrics

This CL makes PasswordManager_SyncCredentialUsed obsolete, beacuse it does not
meaure what it should (see the associated bug).

The CL also introduces a new user action,
PasswordManager_SyncCredentialFilledAndLoginSuccessfull, to actually measure
what the above action was supposed to measure.

The CL also introduces another user action, PasswordManager_ProcessingUpdate,
which keeps measuring what PasswordManager_SyncCredentialUsed measured, because
that data was also useful.

BUG= 635428 

Review-Url: https://codereview.chromium.org/2220423002
Cr-Commit-Position: refs/heads/master@{#410999}

[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/core/browser/credentials_filter.h
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/sync/browser/sync_credentials_filter.cc
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/sync/browser/sync_credentials_filter.h
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
[modify] https://crrev.com/3a69d6d6755a3f7c645ea682d777e55d7d4340b3/tools/metrics/actions/actions.xml

Comment 5 by vabr@chromium.org, Aug 10 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment