Issue metadata
Sign in to add a comment
|
'Search and URL suggestions' appear over search box when long tapped on thumbnail & then on search box immediately
Reported by
kye...@etouch.net,
Aug 8 2016
|
||||||||||||||||||||||
Issue descriptionApplication Version: Chrome 54.0.2823.0 Android Build Number: 5.1.1/LMY48B Device: Samsung Galaxy J7 Precondition: At least 1 Thumbnail(most visited sites) should be present. Steps to reproduce: 1. Launch Chrome> Open a New tab. 2. Long tap on thumbnail & immediately tap on Google search box(Observed context menu). 3. Tap on 'Open in new tab' option> Type something in search box> Observe. Observed behavior: 'Search and URL suggestions' appear over search box. Expected behavior: 'Search and URL suggestions' should appear below search box. Frequency: <5/5> Additional comments: 1.Good build: 54.0.2812.0 Bad build : 54.0.2816.2 2.This issue is not present on latest M-53.0.2785.55 3.This issue is reproducible on Samsung Galaxy S4(5.0.1/LRX22C),Moto g2(6.0/MPB24),Spice Mi-498(6.0.1/MOB30Q),Karbonn Sparkle V(5.1.1/LMY47V),Lenovo A6000 (5.0.2/LRX22G),Samsung Galaxy S3(4.3/JSS15J),Micromax Canvas A1(5.1.0/LMY47O),Samsung Galaxy J7(5.1.1/LMY48B),Samsung Galaxy J2(5.1.1/LMY47X) Bisect Range : https://chromium.googlesource.com/chromium/src/+log/54.0.2812.0..54.0.2816.2?pretty=fuller&n=10000
,
Aug 8 2016
Please find logs and video @ http://go/chrome-androidlogs1/6/635424
,
Sep 13 2016
I don't have access to the video, but based on the description and the bisect range I'm going to suspect this: https://codereview.chromium.org/2204613002
,
Sep 13 2016
Logs and video are now accessible @ http://go/chrome-androidlogs1/6/635424
,
Sep 28 2016
[Bulk edit] This issue is listed as a release block stable for M54 Android. We'll be cutting our stable candidate in just about two weeks, so time is running out to fix this bug - please prioritize working on it ASAP. Are you sure this issue shouldn't block the release? Remove the ReleaseBlock-Stable label. Unsure if this issue should block the release, or know the issue should block the release but we won't be able to fix it in time? CC me so that we can discuss. Thanks!
,
Oct 5 2016
And another issue I can't reproduce (and neither could Patrick) :-/
,
Oct 5 2016
This issue is still reproducible on latest M-54.0.2840.50
,
Oct 6 2016
This issue is still reproducible on latest M-54.0.2840.51 by above mentioned steps, please find attached video.
,
Oct 6 2016
Find new video @ http://go/chrome-androidlogs1/6/635424-1
,
Oct 7 2016
[Bulk edit] URGENT: This issue is marked as an RB-Stable for Android M54. If it is going to block the release, it needs to be fixed ASAP, and merged back to branch 2840 by 5 PM PT Oct 11. Please review and if you cannot get it fixed by then, ping me; if you don't believe you are the right owner, and you cannot find another one - please ping me.
,
Oct 10 2016
,
Oct 10 2016
Ok, I've found out what happens: When a new tab is opened, we detach the NewTabPageView from the window (because the animation is done by the compositor), which sets the URL focus percentage to 0 (https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java?l=860), so the omnibox is moved down to its initial state. I can't think of a trivial fix for this (the problematic line has been around at least since the upstreaming), but given that this is a rare condition that only results in ugliness, I'm removing RB-S.
,
Oct 11 2016
,
Oct 28 2016
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b193b850bec1cfb529bc027fec99870224ea0094 commit b193b850bec1cfb529bc027fec99870224ea0094 Author: bauerb <bauerb@chromium.org> Date: Fri Oct 28 17:07:05 2016 Init search box animation for NTP based on location bar focus state. Because the focus is now set when attaching, the existing code in onDetachedFromWindow() can now be removed, which also fixes another issue ( https://crbug.com/635424#c13 ). BUG=659521, 635424 Review-Url: https://codereview.chromium.org/2460873002 Cr-Commit-Position: refs/heads/master@{#428399} [modify] https://crrev.com/b193b850bec1cfb529bc027fec99870224ea0094/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/b193b850bec1cfb529bc027fec99870224ea0094/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
,
Oct 28 2016
,
Nov 1 2016
This issue is fixed on latest M-56.0.2906.0
,
Nov 1 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kgna...@chromium.org
, Aug 8 2016Labels: -Pri-3 M-54 ReleaseBlock-Stable Pri-2 Type-Bug-Regression
Owner: tedc...@chromium.org
Status: Assigned (was: Unconfirmed)