New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635417 link

Starred by 3 users
Status: Fixed
Owner:
█ qiankun....@intel.com
Email to this user bounced
Closed: Aug 2016
Cc:
█ kbr@chromium.org
yang...@intel.com
zmo@chromium.org
yunchao...@intel.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 295792



Sign in to add a comment

getProgramInfoLog should not return a "\0" string in WebGL

Project Member Reported by qiankun....@intel.com, Aug 8 2016 
In some cases, chrome will return a "\0" string in WebGL when calling getProgramInfoLog. Empty string in js should be "" other than "\0". You can see "".length == 0, but "\0".length == 1. The root cause is that driver returns an empty string for such query glGetProgramInfoLog, but driver returns 1 for length of info log when calling glGetProgramiv(program, GL_INFO_LOG_LENGTH, &length) because the length includes the null terminator. GLES spec 3.0.4 says "If there is no info log, zero is returned." in page 235.

Conformance tests to verify this behavior: https://github.com/KhronosGroup/WebGL/pull/1953.
Some related discussions: https://github.com/mrdoob/three.js/pull/9456.
I proposed a CL to fix this issue: https://codereview.chromium.org/2220933002/.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c54b546d3d2155e9973f7bf8d450c2374026acef

commit c54b546d3d2155e9973f7bf8d450c2374026acef
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Tue Aug 09 02:19:57 2016

Empty program info log should not be a '\0' string in WebGL

BUG= 635417 
TEST=conformance/programs/program-infolog.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2220933002
Cr-Commit-Position: refs/heads/master@{#410527}

[modify] https://crrev.com/c54b546d3d2155e9973f7bf8d450c2374026acef/gpu/command_buffer/service/program_manager.cc

Comment 2 by qiankun....@intel.com, Aug 31 2016

Status: Fixed (was: Assigned)
This is fixed. Close it now.
►

Sign in to add a comment