New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635415 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add more command line feedback to debugd such we can gather more info in user feedback

Project Member Reported by hctsai@google.com, Aug 8 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 8350.60.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.85 Safari/537.36

Steps to reproduce the problem:
Usually we use the shortcut key Alt-Shift-i to file user feedback when we encounter any issues.

What is the expected behavior?

What went wrong?
We need more info to be in the feedback report. For example, when we deal with the samus performance bug, we need to use some pattern to verify performance issue, such as top's thread mode or perf record.

Did this work before? N/A 

Chrome version:   Channel: dev
OS Version: 8350.60.0
Flash Version: Shockwave Flash 22.0 r0
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 8 2016

Labels: Hotlist-Google
Owner: hctsai@chromium.org
Status: Started (was: Unconfirmed)
Cc: bccheng@chromium.org afakhry@chromium.org cywang@chromium.org
Ahmed, I remembered you noticed a place where we might truncate the content of the feedback report. Could you add some pointer here so that we can take care of it too?
I'm currently the owner of the feedback app, so let me know what extra info you want to add.

Regarding the truncated sys info, I recently fixed that bug in  Issue 634518 . system_logs.zip should contain everything now.

Comment 6 by hctsai@chromium.org, Aug 10 2016

Hi Ahmed,

We were planning for adding two sources of the system info into the feedback report for diagnosing performance issues. The first one is the 'thread mode' top which provides better understanding of how the processors are used. (I sent this: https://chromium-review.googlesource.com/#/c/367160/ ). The second one is to provide an option for the user to send a 10-seconds perf record data. The former is easier and straightforward but the latter might involve some ui change. What do you think ?
For UI changes, we have to go through UI review. For the first change, yes, absolutely. Thanks!
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4210f3c955b8dbb6c885fc5caa6afb50f7a55165

commit 4210f3c955b8dbb6c885fc5caa6afb50f7a55165
Author: Hsu-Cheng Tsai <hctsai@google.com>
Date: Fri Aug 05 02:50:19 2016

debugd: Add top (thread mode) to user feedback.

BUG= chromium:635415 
TEST=manual

Change-Id: I687278bf1410e9043db5557b0c0705cd858baffe
Reviewed-on: https://chromium-review.googlesource.com/367160
Commit-Ready: Hsu-Cheng Tsai <hctsai@chromium.org>
Tested-by: Hsu-Cheng Tsai <hctsai@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/4210f3c955b8dbb6c885fc5caa6afb50f7a55165/debugd/src/log_tool.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4210f3c955b8dbb6c885fc5caa6afb50f7a55165

commit 4210f3c955b8dbb6c885fc5caa6afb50f7a55165
Author: Hsu-Cheng Tsai <hctsai@google.com>
Date: Fri Aug 05 02:50:19 2016

debugd: Add top (thread mode) to user feedback.

BUG= chromium:635415 
TEST=manual

Change-Id: I687278bf1410e9043db5557b0c0705cd858baffe
Reviewed-on: https://chromium-review.googlesource.com/367160
Commit-Ready: Hsu-Cheng Tsai <hctsai@chromium.org>
Tested-by: Hsu-Cheng Tsai <hctsai@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/4210f3c955b8dbb6c885fc5caa6afb50f7a55165/debugd/src/log_tool.cc

Status: Fixed (was: Started)
We don't have plan to add new commands in near future yet while 'perf record' is still an option.

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)
Verified in Chrome OS 9667.0.0, 61.0.3130.0. 

Sign in to add a comment