New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635409 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
dbeam@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 608535



Sign in to add a comment

Regression: Search hit yellow rectangle is not always shown.

Reported by dmascare...@etouch.net, Aug 8 2016 
Chrome Version:54.0.2823.1 (Official Build) 787b4d3322f8e433876ccb912291f3239c786a09-refs/branch-heads/2823@{#1} (64-bit)
OS: Mac (10.10.5, 10.11.5), Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/
2. Click on 'Search' field and type 'search' within search field.
3. Scrolldown the page and click on 'Manage Password' and observe.

Actual:Yellow highlight is not seen on 'Search' text (i.e. Ghost text)
Expected:Yellow highlight should be seen on 'Search' text.

This is regression issue,broken in 'M 54' and below is narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/d858f427b0ed6d932975105f8dc9a072da99e3cb..1ec38faa31c347108fc99580ba9e3bb928e615f4?pretty=fuller&n=1000

Suspecting: r410136

Good build:54.0.2820.0
Bad build:54.0.2821.0

Note: Will soon update the Linux OS info.
Actual_search.mp4
308 KB View Download
Exp_search.mp4
316 KB View Download

Comment 1 by dpa...@chromium.org, Aug 8 2016

Cc: dbeam@chromium.org
Labels: Proj-MaterialDesign-WebUI
Summary: Regression: Search hit yellow rectangle is not always shown. (was: Regression: Yellow highlight is not seen on 'Search' text within 'chrome://md-settings/managePasswords')
I am rephrasing the description to depict the underlying issue better.

This is caused because by https://codereview.chromium.org/2202723004, because I moved the background color style rule from JS to CSS, and some elements do not use the settings-shared style.

@dbeam: Thinking about moving the background color style back to JS. I could alternatively find all elements that don't use settings-shared, and apply it, but some of them are not even under the settings/ directory, for example elements under https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/network. Any thoughts?

Comment 2 by dpa...@chromium.org, Aug 8 2016

Blocking: 608535

Comment 3 by dpa...@chromium.org, Aug 8 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f4f58077e1226254d3eb0c794e4c6876951df07

commit 0f4f58077e1226254d3eb0c794e4c6876951df07
Author: dpapad <dpapad@chromium.org>
Date: Tue Aug 09 23:18:34 2016

MD Settings: Fix missing yellow rectangle highlighting.

BUG= 635409 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2226883002
Cr-Commit-Position: refs/heads/master@{#410864}

[modify] https://crrev.com/0f4f58077e1226254d3eb0c794e4c6876951df07/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/0f4f58077e1226254d3eb0c794e4c6876951df07/chrome/browser/resources/settings/settings_shared_css.html

Comment 5 by dpa...@chromium.org, Aug 10 2016

Status: Fixed (was: Started)

Comment 6 by ssamanoori@chromium.org, Aug 16 2016

Labels: TE-Verified-54.0.2830.0 TE-Verified-M54
Tested the issue on Windows 7, Mac 10.11.6 using 54.0.2830.0.Yellow highlight is  seen on 'Search' text on 'Manage password'.
Please find attached screencast.

Marking it as TE-Verified.
635409.mp4
363 KB View Download
►

Sign in to add a comment